Skip to content

Commit

Permalink
Updated readme instructions on desktop build actions
Browse files Browse the repository at this point in the history
  • Loading branch information
albbus-stack committed May 24, 2024
1 parent f15923c commit dbc4739
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/linux.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build Desktop App (Linux - deb)
name: Build Desktop App (Linux .deb)

on:
# push:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: Build Desktop App (Windows)
name: Build Desktop App (Windows .msi)

on:
push:
branches:
- master
# push:
# branches:
# - master
# pull_request:
# branches:
# - master
Expand Down Expand Up @@ -57,4 +57,4 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: windows
path: dist/bundle/msi/
path: dist/bundle/msi/**/*.msi
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,8 @@ DATABASE_URL

### Desktop

> Github actions for the Linux and MacOS platforms are not yet functioning since `dx bundle` fails with various errors.
> The Github action for MacOS is not yet implemented. Linux is barely functioning since the built bundle fails with various errors (e.g the installed .deb package searches assets in the folder where you call it and not globally). Windows is the only platform that works correctly for now.
- For Windows you can configure the `.github/workflows/windows.yaml` workflow to build and upload the `.msi` installer in the action artifacts on every push to the `master` branch or manually with the `workflow_dispatch` event.
- For Linux you can configure the `.github/workflows/linux.yaml` workflow to build and upload the `.deb` package along with the dist folder in the action artifacts on every push to the `master` branch or manually with the `workflow_dispatch` event.
- Currently `dx bundle` is being actively developed and is not yet ready for production use, so you should use `dx build` if bundling fails on other platforms (this is not good since you need attach the entire `dist` folder to your release build).

0 comments on commit dbc4739

Please sign in to comment.