fix(client): race- and timeout-free -bblock
#423
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The old
-bblock
relied on CometBFT's/tx_broadcast_commit
endpoint, with its arbitrary, implicit 30 second timeout for block inclusion. This PR reimplements thetx -bblock
flag with a subscribe(txhash)-broadcast(sync)-wait(txhash-inclusion), with no timeout.It would be interesting to make this more robust, and offer the mechanism as a new CLI command (
agd query wait-for ...
?), as well as a flag (--wait-for=<condition>
?) added to allagd tx ...
andagd query tx ...
.The idea would be to give power to calling scripts using the default
-bsync
to obtain the txHash, then code their own timeouts and/or retry loops.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change