-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get rid of -bblock
in cli tooling
#10746
Comments
I believe our plan is to keep support of |
Correct, we will make it more reliable than ever before! See agoric-labs/cosmos-sdk#423 Having an implementation within Closing this issue as "not planned." |
Oh, maybe I didn’t actually clarify. |
In cosmos-sdk I've seen that |
It's not related to SwingSet, it's related to multiple calls to |
Alright, thanks Micheal! I think I need to do a little bit more research on broadcast modes and how clients are effected from the events happening between mempool and block inclusion. Maybe then I can bother you again. |
Context
As of
v0.47
ofcosmos-sdk
,block
broadcast mode is deprecated. See ChangeLog.We've seen this caused some issues in our acceptance tests. See #10728.
Currently,
agoric wallet send
uses-bblock
:agoric-sdk/packages/agoric-cli/src/commands/wallet.js
Line 175 in 7b7ceb9
I assume we should remove
-bblock
and start using default optionsync
. Thoughts? @turadg @LuqiPancc @Chris-Hibbert
The text was updated successfully, but these errors were encountered: