Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGS 4: Remove built-in Score functionality #2201

Merged

Conversation

ivan-mogilko
Copy link
Contributor

@ivan-mogilko ivan-mogilko commented Oct 26, 2023

This is a suggestion, but I think that it goes in line with the general idea of cutting built-in functionality that is

  • may be easily implemented in game script;
  • has narrow use in contemporary games.

This PR completely removes Score functionality, which includes:

  • Total score / current score variables;
  • GiveScore script command, and associated sound setting;
  • "give-score" command in dialog script;
  • @SCORE@ and related label macros.

Removed:
* score variables;
* GiveScore() script function;
* "got score" event;
* @score@ and related label macros;
* Marked MaximumScore and PlaySoundOnScore properties as obsolete;
* Removed "give-score" dialog script command;
* Removed GiveScore() and score-related variables from script API.
@ivan-mogilko ivan-mogilko added ags 4 related to the ags4 development context: script api labels Oct 26, 2023
@ivan-mogilko ivan-mogilko merged commit 1060255 into adventuregamestudio:ags4 Oct 28, 2023
20 checks passed
@ivan-mogilko ivan-mogilko deleted the ags4--removehardscore branch October 28, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ags 4 related to the ags4 development context: script api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant