Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGS4: Rename "Sound" --> "Score" in General Settings #1267

Closed
fernewelten opened this issue Apr 27, 2021 · 2 comments
Closed

AGS4: Rename "Sound" --> "Score" in General Settings #1267

fernewelten opened this issue Apr 27, 2021 · 2 comments

Comments

@fernewelten
Copy link
Contributor

There is a "Sound" category on the General Settings screen. It has just one entry: "Play sound when the player gets points". At core, this is a score related matter, not a sound related matter. In a "Sound" category you'd expect entries such as whether threaded audio or Midi sound is enabled. But those issues are all handled in the "Audio" category of "Default setup".

So I'd like to suggest renaming the "Sound" category to "Score". There's another score related field on the General Settings screen: "Maximum possible score" in "(Basic properties)". This field should be moved to this new "Score" category, too.

@ivan-mogilko
Copy link
Contributor

ivan-mogilko commented Apr 27, 2021

Perhaps it would be better to deprecate and remove both settings? Both are ancient options meant to emulate classic Sierra games.
Score and score sound may be easily implemented in script where necessary.

@ivan-mogilko ivan-mogilko added the ags 4 related to the ags4 development label Apr 27, 2021
@ivan-mogilko ivan-mogilko removed the ags 4 related to the ags4 development label Oct 26, 2023
@ivan-mogilko
Copy link
Contributor

Did this in 3.6.1: af61c8b

For 4.0 opened a PR which removes built-in score feature instead: #2201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants