Skip to content

Commit

Permalink
Deploy Error Fix 🎫 (#10)
Browse files Browse the repository at this point in the history
* Attempting new deployment

* adding different logging

* removing logs

* pushing changelog update
  • Loading branch information
NickLiffen authored Dec 6, 2021
1 parent d58eeed commit 917c553
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 24 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [v1.1.1](https://github.com/NickLiffen/GSSAR/releases/v1.1.1) - 2021-12-06

- Removed Logging that was failing the stack build

## [v1.1.0](https://github.com/NickLiffen/GSSAR/releases/v1.1.0) - 2021-12-06

- Better Codespaces setup
Expand Down
24 changes: 0 additions & 24 deletions template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,6 @@ Description: >
GitHub Secret Scanner Auto Remediator (GSSAR)
Resources:
### Log Groups ###

HttpApiAccessLogs:
Type: "AWS::Logs::LogGroup"

SecretScannerStateMachineLogGroup:
Type: AWS::Logs::LogGroup
Properties:
RetentionInDays: 7

### Lambda Functions ###

## Authorizers
Expand Down Expand Up @@ -151,14 +141,6 @@ Resources:
HttpApi:
Type: AWS::Serverless::HttpApi
Properties:
AccessLogSettings:
DestinationArn: !GetAtt HttpApiAccessLogs.Arn
Format: >-
{ "requestId":"$context.requestId","ip": "$context.identity.sourceIp",
"requestTime":"$context.requestTime","httpMethod":"$context.httpMethod",
"routeKey":"$context.routeKey","status":"$context.status",
"protocol":"$context.protocol","responseLength":"$context.responseLength",
"error" : $context.authorizer.error }
FailOnWarnings: True
RouteSettings:
"POST /github/webhook/validate":
Expand Down Expand Up @@ -249,12 +231,6 @@ Resources:
- custom.kickOffSecretScanRemediation
detail-type:
- transaction
Logging:
Destinations:
- CloudWatchLogsLogGroup:
LogGroupArn: !GetAtt SecretScannerStateMachineLogGroup.Arn
IncludeExecutionData: true
Level: ALL
Policies:
- LambdaInvokePolicy:
FunctionName: !Ref GitHubWebhookSecretValidator
Expand Down

0 comments on commit 917c553

Please sign in to comment.