Prepare for future news templates #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
jtfell
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops support for some obsolete and unused environments and adds support for detecting the upcoming future news templates.
There is no clean spot to add that detection in the current API since future news is neither a new generation or a different app. On balance I thought it made most sense to detect it as a separate app, so that's what it does.
getApplication()should now return a new value ofplnf(PL News Future) if it detects the future news templates.Additionally, this removes the
getEnvironment()function. From a search of dependencies on GitHub, I can't find anywhere it's used and the current implementation is unreliable due to the way domains are now mapped to environments (by which we actually mean databases).