Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getEnvironment returns incorrect results #13

Closed
drzax opened this issue Mar 24, 2021 · 3 comments
Closed

getEnvironment returns incorrect results #13

drzax opened this issue Mar 24, 2021 · 3 comments

Comments

@drzax
Copy link
Member

drzax commented Mar 24, 2021

A change to the domain names used for the various preview environments available means that getEnvironment is now returning incorrect results for (non-prod) outputs.

The main change is that PL previews have been switched to use the develop deployment rather than the preview deployment. There is information about the various PL deployments available. But it all needs to be verified in the real world.

@drzax drzax changed the title getTier and getEnvironment return incorrect results getEnvironment returns incorrect results Mar 24, 2021
@drzax
Copy link
Member Author

drzax commented Nov 2, 2022

I propose we remove getEnvironment. I think it was initially added for completeness, but:

  • I don't know of any dependencies using it
  • It's not currently working
  • The need for it is unclear
  • The environment can't be detected by hostname as it used to be, so this would require a new detection method — effort that I don't think is necessary.

@phocks
Copy link
Member

phocks commented Nov 2, 2022

Agree.

@drzax
Copy link
Member Author

drzax commented Jun 10, 2024

Removed in #29

@drzax drzax closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants