Suggestion for "Update zcash_proofs from 0.13.0-rc.1 to 0.14.0" #8548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…epends on from `zcash_proofs`
9 tasks
oxarbitrage
approved these changes
May 18, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 21, 2024
…8527) * update zcash_proofs to 0.14 using custom sapling * remove OnceLock * Copies `parse_parameters()` function and other private functions it depends on from `zcash_proofs` (#8548) * add links to copied code * use upstream proofs and sapling --------- Co-authored-by: Arya <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a suggestion PR for #8522 that copies the
parse_parameters()function into Zebra to provide access to the inner values of the new types,sapling::circuit::{SpendParameters, PreparedSpendVerifyingKey, OutputParameters, PreparedOutputVerifyingKey}.Review
@oxarbitrage can review and merge.