-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(zcash_proofs): Update zcash_proofs from 0.13.0-rc.1 to 0.14.0 #8527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxarbitrage
added
A-dependencies
Area: Dependency file updates
do-not-merge
Tells Mergify not to merge this PR
labels
May 14, 2024
arya2
changed the title
deps(cash_proofs): Update zcash_proofs to 0.14
deps(zcash_proofs): Update zcash_proofs from 0.13.0-rc.1 to 0.14.0
May 14, 2024
oxarbitrage
commented
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments.
arya2
reviewed
May 15, 2024
oxarbitrage
added
P-Medium ⚡
and removed
do-not-merge
Tells Mergify not to merge this PR
labels
May 18, 2024
upbqdn
approved these changes
May 21, 2024
5 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR updates
zcash_proofs
and introducessapling-crypto
tozebra-consensus
.PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
Copies some code from zcash_proofs into zebra, this is done in
parse_parameters.rs
. This will save us from making changes upstream.Testing
All tests are passing locally.
Review
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work