Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(zcash_proofs): Update zcash_proofs from 0.13.0-rc.1 to 0.14.0 #8527

Merged
merged 7 commits into from
May 21, 2024

Conversation

oxarbitrage
Copy link
Contributor

@oxarbitrage oxarbitrage commented May 14, 2024

Motivation

This PR updates zcash_proofs and introduces sapling-crypto to zebra-consensus.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

Copies some code from zcash_proofs into zebra, this is done in parse_parameters.rs. This will save us from making changes upstream.

Testing

All tests are passing locally.

Review

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

@oxarbitrage oxarbitrage added A-dependencies Area: Dependency file updates do-not-merge Tells Mergify not to merge this PR labels May 14, 2024
@arya2 arya2 changed the title deps(cash_proofs): Update zcash_proofs to 0.14 deps(zcash_proofs): Update zcash_proofs from 0.13.0-rc.1 to 0.14.0 May 14, 2024
Copy link
Contributor Author

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

zebra-consensus/src/primitives/groth16.rs Outdated Show resolved Hide resolved
zebra-consensus/src/primitives/groth16.rs Outdated Show resolved Hide resolved
zebra-consensus/src/primitives/groth16.rs Outdated Show resolved Hide resolved
zebra-consensus/Cargo.toml Outdated Show resolved Hide resolved
zebra-consensus/Cargo.toml Outdated Show resolved Hide resolved
@oxarbitrage oxarbitrage marked this pull request as ready for review May 18, 2024 19:52
@oxarbitrage oxarbitrage requested review from a team as code owners May 18, 2024 19:52
@oxarbitrage oxarbitrage requested review from upbqdn and removed request for a team May 18, 2024 19:52
@oxarbitrage oxarbitrage added P-Medium ⚡ and removed do-not-merge Tells Mergify not to merge this PR labels May 18, 2024
mergify bot added a commit that referenced this pull request May 21, 2024
@mergify mergify bot merged commit b06a122 into main May 21, 2024
137 checks passed
@mergify mergify bot deleted the upgrade-zcash-proofs branch May 21, 2024 18:24
@mpguerra mpguerra linked an issue May 22, 2024 that may be closed by this pull request
@upbqdn upbqdn mentioned this pull request Jun 28, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Area: Dependency file updates P-Medium ⚡
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deps: Upgrade zcash_proofs and zcash_primitives in Zebra
3 participants