Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RWRoute] Add --lutRoutethru option #932
[RWRoute] Add --lutRoutethru option #932
Changes from all commits
880e651
621affc
92435bf
e2f9e29
e5b6583
10079bc
045ca05
e5223f9
bcf4380
46999c2
c17988e
c2a74f3
b4e0d11
da94aed
59cf442
7058c8c
6ec4437
e84941f
fbebb76
b8c753a
26c3c51
6a1d87f
c742283
b049714
888651b
ba5cb07
30106a7
79fcad4
79ad0e4
ba9f017
dd44e18
03afd1e
d035795
5bae2e0
d6a2ab4
a2ecc9f
cbd8156
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you demonstrate that this doesn't cause an error when importing the designs back into Vivado? Unless a placed cell exists (which a route thru may suffice), my understanding is that this could lead to an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing a breakpoint hit this line in the newly added test
testNonTimingDrivenFullRoutingWithLutRoutethru
withbnn.dcp
forSLICE_X79Y201
, and foroptical-flow.dcp
forSLICE_X66Y252
and 10 others.For
bnn.dcp
, even after RWRoute is done, thatSiteInst
has no placed cells (recall that thru-site PIPs do not show up as routethru cells), yet Vivado 2022.1 seems to accept it just fine and reports a clean routing result.(highlighted net is
GLOBAL_LOGIC0
; rest of slice is completely empty aside from these two routethrus)Vivado 2022.1 also accepts this
optical-flow.dcp
routed result.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to upgrade our terminology as there are "routethrus" that terminate at a cell in the site and
other "routethrus" that don't (being specified by a
PIP
).