Multisig grant and admit messages and fixes in seqner #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 9, 2023 14:37
Codecov Report
@@ Coverage Diff @@
## development #133 +/- ##
===============================================
+ Coverage 80.94% 80.97% +0.02%
===============================================
Files 42 42
Lines 4173 4178 +5
Branches 1028 1028
===============================================
+ Hits 3378 3383 +5
Misses 763 763
Partials 32 32
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
nkongsuwan
reviewed
Nov 12, 2023
| @@ -197,7 +105,7 @@ async function run() { | |||
| // First member start the creation of a multisig identifier | |||
| let rstates = [aid1['state'], aid2['state'], aid3['state']]; | |||
There was a problem hiding this comment.
When three clients are hosted on different machines, or even on different shells, they will not be able to directly obtain other clients' states directly like in this examples.
I suggest adding client.keyStates().get(...) for each client to obtain other clients' states.
There was a problem hiding this comment.
You are correct, in a real scenario you should keep track of the states independently.
pfeairheller
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces PR #124. It adds examples on the integration script
multisig.tsshowing how to passgrantandadmitmessages between a multisig issuer and a single sig holder.It also fixed a serialization error on the seqner and holder that used little endian instead of big endian. Test results were validated against tests in
keripy