Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add credential and ipex to multisig integration script #124

Closed

Conversation

rodolfomiranda
Copy link
Collaborator

No description provided.

@rodolfomiranda rodolfomiranda marked this pull request as draft October 30, 2023 11:24
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #124 (4aab838) into development (6282052) will decrease coverage by 0.06%.
Report is 12 commits behind head on development.
The diff coverage is 78.46%.

@@               Coverage Diff               @@
##           development     #124      +/-   ##
===============================================
- Coverage        80.90%   80.85%   -0.06%     
===============================================
  Files               42       42              
  Lines             4117     4178      +61     
  Branches          1027     1028       +1     
===============================================
+ Hits              3331     3378      +47     
- Misses             754      768      +14     
  Partials            32       32              
Files Coverage Δ
src/keri/core/serder.ts 63.63% <100.00%> (+2.19%) ⬆️
src/keri/core/utils.ts 68.23% <97.36%> (+23.55%) ⬆️
src/keri/app/exchanging.ts 90.62% <16.66%> (-7.69%) ⬇️
src/keri/app/credentialing.ts 83.27% <50.00%> (-2.23%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@rodolfomiranda rodolfomiranda marked this pull request as ready for review November 9, 2023 11:12
@m00sey
Copy link
Member

m00sey commented Nov 9, 2023

can you rebase and clean up the commit history? :)

@rodolfomiranda
Copy link
Collaborator Author

can you rebase and clean up the commit history? :)

I did rebase, but still appearing the changes that were already merged. I don't know how to fix. It may be better to create a new PR with multisig.ts that is the only file modified.

@rodolfomiranda
Copy link
Collaborator Author

replaced by PR #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants