Fix / Reintroduce profile menu styling #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langemike
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
MelissaDTH
approved these changes
May 1, 2024
|
If we want to define our styles in the parent component and pass them as classname props, then we need to find a solution for the |
langemike
temporarily deployed
to
Deployment Previews
GitHub Actions
Inactive
royschut
approved these changes
May 2, 2024
langemike
added
pr-submitted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A styling bug has been introduced in the profile menu during the header refactor jwplayer#501
The style references were unused in
ProfileMenu. I moved the styling definitions one parent up, so the style references work. But I also need to re-use these (on the new location) for theUserMenuNav. This will make both these components similar in styling behavior.I also deleted
UserMenuNav.module.scssbecause the only remaining selector was.button, but that definition is unused.Situation before fix:
Ticket: https://videodock.atlassian.net/browse/OTT-1510