Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / Reintroduce profile menu styling #527

Merged
merged 2 commits into from
May 17, 2024

Conversation

langemike
Copy link
Collaborator

A styling bug has been introduced in the profile menu during the header refactor #501

The style references were unused in ProfileMenu. I moved the styling definitions one parent up, so the style references work. But I also need to re-use these (on the new location) for the UserMenuNav. This will make both these components similar in styling behavior.

I also deleted UserMenuNav.module.scss because the only remaining selector was .button, but that definition is unused.

Situation before fix:
Screenshot 2024-04-30 102125

Original PR in our repo: Videodock#194

@langemike langemike requested review from dbudzins and AntonLantukh May 7, 2024 06:53
@AntonLantukh AntonLantukh merged commit 26aee88 into jwplayer:develop May 17, 2024
8 of 9 checks passed
@royschut royschut deleted the fix/profile-menu-styling branch May 28, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants