Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix / Adhere icon button styling & don’t act as a submit button #177

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Fix / Adhere icon button styling & don’t act as a submit button #177

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
959c800
chore: adhere icon button styling & don’t act as a submit button
langemike Apr 10, 2024
516b3ba
chore: update snapshots for buttons
langemike Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui-react/src/components/IconButton/IconButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ type Props = ButtonHTMLAttributes<HTMLButtonElement> & {

const IconButton: React.FC<Props> = ({ children, onClick, className, ...ariaProps }: Props) => {
return (
<button className={classNames(styles.iconButton, className)} onClick={onClick} {...ariaProps}>
<button className={classNames(styles.iconButton, className)} type="button" onClick={onClick} {...ariaProps}>
{children}
</button>
);
Expand Down
2 changes: 1 addition & 1 deletion packages/ui-react/src/components/TextField/TextField.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
}
}

.control > div {
.control > button {
width: 48px;
height: 48px;
}
Expand Down
Loading