Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / Adhere icon button styling & don’t act as a submit button #177

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

langemike
Copy link

Fixes 2 issues we experienced with the icon button:

  • Don’t act as a submit button (happened on the signin modal due to the "show password" button)
  • Adhere the styling when an IconButton is used as a control within a TextField

Fixes: https://videodock.atlassian.net/browse/OTT-1266 & https://videodock.atlassian.net/browse/OTT-1274

Copy link

@royschut royschut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!
Snapshots. :-)

@ChristiaanScheermeijer
Copy link
Member

Snapshots indeed 😄

@langemike langemike temporarily deployed to Deployment Previews April 11, 2024 09:36 — with GitHub Actions Inactive
@langemike
Copy link
Author

Snapshots updated!

@MelissaDTH MelissaDTH merged commit 4c0a198 into feat/accessibility-sprint-4 Apr 11, 2024
7 checks passed
@MelissaDTH MelissaDTH deleted the fix/icon-button branch April 11, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants