Fix / Adhere icon button styling & don’t act as a submit button #620
langemikeAnnotations
10 errors and 1 warning
|
src/containers/Cinema/Cinema.test.tsx > <Cinema> > renders and matches snapshot:
packages/ui-react/src/containers/Cinema/Cinema.test.tsx#L54
Error: Snapshot `<Cinema> > renders and matches snapshot 1` mismatched
- Expected
+ Received
@@ -36,10 +36,11 @@
class="_playerContent_555f3c"
>
<button
aria-label="common:back"
class="_iconButton_0fef65 _backButton_555f3c"
+ type="button"
>
<svg
aria-hidden="true"
class="_icon_585b29"
viewBox="0 0 24 24"
❯ src/containers/Cinema/Cinema.test.tsx:54:25
|
|
src/containers/Layout/Layout.test.tsx > <Layout /> > renders layout:
packages/ui-react/src/containers/Layout/Layout.test.tsx#L20
Error: Snapshot `<Layout /> > renders layout 1` mismatched
- Expected
+ Received
@@ -22,10 +22,11 @@
aria-controls="sidebar"
aria-expanded="false"
aria-haspopup="true"
aria-label="open_menu"
class="_iconButton_0fef65 _iconButton_f4f7a7"
+ type="button"
>
<svg
aria-hidden="true"
class="_icon_585b29"
viewBox="0 0 24 24"
@@ -77,10 +78,11 @@
class="_heading_577f70"
>
<button
aria-label="close_menu"
class="_iconButton_0fef65"
+ type="button"
>
<svg
aria-hidden="true"
class="_icon_585b29"
viewBox="0 0 24 24"
❯ src/containers/Layout/Layout.test.tsx:20:23
|
|
src/components/CheckoutForm/CheckoutForm.test.tsx > <CheckoutForm> > renders and matches snapshot:
packages/ui-react/src/components/CheckoutForm/CheckoutForm.test.tsx#L35
Error: Snapshot `<CheckoutForm> > renders and matches snapshot 1` mismatched
- Expected
+ Received
@@ -214,10 +214,11 @@
</div>
</div>
<button
aria-label="common:back"
class="_iconButton_0fef65 _dialogBackButton_248199"
+ type="button"
>
<svg
aria-hidden="true"
class="_icon_585b29"
viewBox="0 0 24 24"
❯ src/components/CheckoutForm/CheckoutForm.test.tsx:35:23
|
|
src/components/Dialog/Dialog.test.tsx > <Dialog> > renders and matches snapshot:
packages/ui-react/src/components/Dialog/Dialog.test.tsx#L18
Error: Snapshot `<Dialog> > renders and matches snapshot 1` mismatched
- Expected
+ Received
@@ -33,10 +33,11 @@
>
Dialog contents
<button
aria-label="close_modal"
class="_iconButton_0fef65 _modalCloseButton_b92d69"
+ type="button"
>
<svg
aria-hidden="true"
class="_icon_585b29"
viewBox="0 0 24 24"
❯ src/components/Dialog/Dialog.test.tsx:18:25
|
|
src/components/DialogBackButton/DialogBackButton.test.tsx > <DialogBackButton> > renders and matches snapshot:
packages/ui-react/src/components/DialogBackButton/DialogBackButton.test.tsx#L10
Error: Snapshot `<DialogBackButton> > renders and matches snapshot 1` mismatched
- Expected
+ Received
@@ -1,9 +1,10 @@
<div>
<button
aria-label="common:back"
class="_iconButton_0fef65 _dialogBackButton_248199"
+ type="button"
>
<svg
aria-hidden="true"
class="_icon_585b29"
viewBox="0 0 24 24"
❯ src/components/DialogBackButton/DialogBackButton.test.tsx:10:23
|
|
src/components/EditPasswordForm/EditPasswordForm.test.tsx > <EditPasswordForm> > renders and matches snapshot:
packages/ui-react/src/components/EditPasswordForm/EditPasswordForm.test.tsx#L19
Error: Snapshot `<EditPasswordForm> > renders and matches snapshot 1` mismatched
- Expected
+ Received
@@ -37,10 +37,11 @@
>
<button
aria-label="reset.view_password"
aria-pressed="false"
class="_iconButton_0fef65"
+ type="button"
>
<svg
aria-hidden="true"
class="_icon_585b29"
viewBox="0 0 24 24"
@@ -89,10 +90,11 @@
>
<button
aria-label="reset.view_password"
aria-pressed="false"
class="_iconButton_0fef65"
+ type="button"
>
<svg
aria-hidden="true"
class="_icon_585b29"
viewBox="0 0 24 24"
❯ src/components/EditPasswordForm/EditPasswordForm.test.tsx:19:23
|
|
src/components/Header/Header.test.tsx > <Header /> > renders header:
packages/ui-react/src/components/Header/Header.test.tsx#L53
Error: Snapshot `<Header /> > renders header 1` mismatched
- Expected
+ Received
@@ -18,10 +18,11 @@
aria-controls="sidebar"
aria-expanded="false"
aria-haspopup="true"
aria-label="open_menu"
class="_iconButton_0fef65 _iconButton_f4f7a7"
+ type="button"
>
<svg
aria-hidden="true"
class="_icon_585b29"
viewBox="0 0 24 24"
@@ -46,10 +47,11 @@
class="_actions_f4f7a7"
>
<button
aria-label="Open search"
class="_iconButton_0fef65 _iconButton_f4f7a7 _actionButton_f4f7a7"
+ type="button"
>
<svg
aria-hidden="true"
class="_icon_585b29"
viewBox="0 0 24 24"
❯ src/components/Header/Header.test.tsx:53:23
|
|
src/components/IconButton/IconButton.test.tsx > <IconButton> > renders and matches snapshot:
packages/ui-react/src/components/IconButton/IconButton.test.tsx#L15
Error: Snapshot `<IconButton> > renders and matches snapshot 1` mismatched
- Expected
+ Received
@@ -1,9 +1,10 @@
<div>
<button
aria-label="Icon button"
class="_iconButton_0fef65"
+ type="button"
>
<svg
viewBox="0 0 24 24"
xmlns="http://www.w3.org/2000/svg"
>
❯ src/components/IconButton/IconButton.test.tsx:15:23
|
|
src/components/LanguageMenu/LanguageMenu.test.tsx > <LanguageMenu> > renders and matches snapshot:
packages/ui-react/src/components/LanguageMenu/LanguageMenu.test.tsx#L38
Error: Snapshot `<LanguageMenu> > renders and matches snapshot 1` mismatched
- Expected
+ Received
@@ -4,10 +4,11 @@
aria-expanded="false"
aria-haspopup="menu"
aria-label="language_menu"
class="_iconButton_0fef65"
data-testid="language-menu-button"
+ type="button"
>
<svg
aria-hidden="true"
class="_icon_585b29"
viewBox="0 0 24 24"
❯ src/components/LanguageMenu/LanguageMenu.test.tsx:38:23
|
|
src/components/LoginForm/LoginForm.test.tsx > <LoginForm> > renders and matches snapshot:
packages/ui-react/src/components/LoginForm/LoginForm.test.tsx#L50
Error: Snapshot `<LoginForm> > renders and matches snapshot 1` mismatched
- Expected
+ Received
@@ -84,10 +84,11 @@
>
<button
aria-label="login.view_password"
aria-pressed="false"
class="_iconButton_0fef65"
+ type="button"
>
<svg
aria-hidden="true"
class="_icon_585b29"
viewBox="0 0 24 24"
❯ src/components/LoginForm/LoginForm.test.tsx:50:23
|
|
test (18.x)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|