-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump DynamicPPL compat to 0.30 #2376
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2376 +/- ##
=======================================
Coverage 86.39% 86.39%
=======================================
Files 22 22
Lines 1573 1573
=======================================
Hits 1359 1359
Misses 214 214 ☔ View full report in Codecov by Sentry. |
Two of the failing tests: using Turing
import ReverseDiff
alg = HMC(0.01, 5; adtype=AutoReverseDiff())
@model function vdemo6()
x = Vector{Real}(undef, 10)
@. x ~ InverseGamma(2, 3)
end
sample(vdemo6(), alg, 10)
@model function vdemo7()
x = Array{Real}(undef, N, N)
@. x ~ [InverseGamma(2, 3) for i in 1:N]
end
sample(vdemo7(), alg, 1000) Bisects to TuringLang/DynamicPPL.jl@c38e65f, i.e. TuringLang/DynamicPPL.jl#555 It seems to only happen with InverseGamma, if it's replaced with
The top-right is the only one that fails. I commented out these lines: and when rerun,
But it still errors. So the problem is with ReshapeTransform rather than UnwrapSingletonTransform – but apparently only when it's composed with |
Pull Request Test Coverage Report for Build 11520126094Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
MWE that doesn't involve DynamicPPL at all: import ReverseDiff
f(x) = exp.(reshape(vec(x), ()))
f([1.0]) # this is fine
ReverseDiff.gradient(f, [1.0]) # this errors Here Reported upstream JuliaDiff/ReverseDiff.jl#265 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @penelopeysm!
Do not merge – seeing where CI breaksTests fixed via TuringLang/DynamicPPL.jl#699.
Closes #2377
Closes #2378