-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Special-case ReshapeTransform for singleton inputs #699
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #699 +/- ##
=======================================
Coverage 79.22% 79.23%
=======================================
Files 30 30
Lines 4212 4214 +2
=======================================
+ Hits 3337 3339 +2
Misses 875 875 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11510571276Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 11516553436Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this!
Great stuff @penelopeysm :) |
Closes #698.
I can confirm that this change fixes the two Turing tests that I listed here TuringLang/Turing.jl#2376 (comment). It might well fix all the other tests too, since they are giving the same error message.