Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer some test utility function into DynamicPPL #2049

Conversation

yebai
Copy link
Member

@yebai yebai commented Jul 20, 2023

@yebai
Copy link
Member Author

yebai commented Jul 21, 2023

There is an error with the Tracker AD backend.

PDMatDistribution AD: Error During Test at /home/runner/work/Turing.jl/Turing.jl/test/essential/ad.jl:98
  Got exception outside of a @test
  MethodError: no method matching Float64(::Tracker.TrackedReal{Float64})
  Closest candidates are:
    (::Type{T})(::Real, ::RoundingMode) where T<:AbstractFloat at /opt/hostedtoolcache/julia/1.7.3/x64/share/julia/base/rounding.jl:200
    (::Type{T})(::T) where T<:Number at /opt/hostedtoolcache/julia/1.7.3/x64/share/julia/base/boot.jl:770
    (::Type{T})(::AbstractChar) where T<:Union{AbstractChar, Number} at /opt/hostedtoolcache/julia/1.7.3/x64/share/julia/base/char.jl:50
    ...

@devmotion do you know any potential cause for this error? It is worth noting this error is not related to this PR but rather relaxing the compat constraint to use the most recent Bijectors as #2018
and DynamicPPL TuringLang/DynamicPPL.jl#462

@yebai yebai merged commit c7b0a30 into compathelper/new_version/2023-06-20-00-28-18-752-01921173878 Jul 21, 2023
0 of 11 checks passed
@yebai yebai deleted the yebai-patch-1 branch July 21, 2023 13:57
yebai added a commit that referenced this pull request Jul 27, 2023
* CompatHelper: bump compat for Bijectors to 0.13, (keep existing compat)

* Update Project.toml

* Replacement for #2039 (#2040)

* Fix testset for external samplers

* Update abstractmcmc.jl

* Update test/contrib/inference/abstractmcmc.jl

Co-authored-by: Tor Erlend Fjelde <[email protected]>

* Update test/contrib/inference/abstractmcmc.jl

Co-authored-by: Tor Erlend Fjelde <[email protected]>

* Update FillArrays compat to 1.4.1 (#2035)

* Update FillArrays compat to 1.4.0

* Update test compat

* Try to enable ReverseDiff tests

* Update Project.toml

* Update Project.toml

* Bump version

* Revert dependencies on FillArrays (#2042)

* Update Project.toml

* Update Project.toml

* Fix redundant definition of `getstats` (#2044)

* Fix redundant definition of `getstats`

* Update Inference.jl

* Revert "Update Inference.jl"

This reverts commit e4f51c2.

* Bump version

---------

Co-authored-by: Hong Ge <[email protected]>

* Transfer some test utility function into DynamicPPL (#2049)

* Update OptimInterface.jl

* Only run optimisation tests in numerical stage.

* fix function lookup after moving functions

---------

Co-authored-by: Xianda Sun <[email protected]>

* Move Optim support to extension (#2051)

* Move Optim support to extension

* More imports

* Update Project.toml

---------

Co-authored-by: Hong Ge <[email protected]>

---------

Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: haris organtzidis <[email protected]>
Co-authored-by: Tor Erlend Fjelde <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: Xianda Sun <[email protected]>
Co-authored-by: Cameron Pfiffer <[email protected]>
yebai added a commit that referenced this pull request Aug 16, 2023
…t) (#2018)

* CompatHelper: bump compat for Bijectors to 0.13, (keep existing compat)

* Update Project.toml

* Replacement for #2039 (#2040)

* Fix testset for external samplers

* Update abstractmcmc.jl

* Update test/contrib/inference/abstractmcmc.jl

Co-authored-by: Tor Erlend Fjelde <[email protected]>

* Update test/contrib/inference/abstractmcmc.jl

Co-authored-by: Tor Erlend Fjelde <[email protected]>

* Transfer some test utility function into DynamicPPL (#2049)

* Update OptimInterface.jl

* Only run optimisation tests in numerical stage.

* fix function lookup after moving functions

---------

Co-authored-by: Xianda Sun <[email protected]>

* Remove tracker tests.

* Update Project.toml

* Update Project.toml

* Update Project.toml

---------

Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: Hong Ge <[email protected]>
Co-authored-by: haris organtzidis <[email protected]>
Co-authored-by: Tor Erlend Fjelde <[email protected]>
Co-authored-by: Xianda Sun <[email protected]>
Co-authored-by: Cameron Pfiffer <[email protected]>
yebai added a commit that referenced this pull request Aug 16, 2023
* first draft

* abstractcontext + tests

* bug

* externalsampler() in tests

* Name Tupple problems

* moving stuff to DynamicPPL RP

* using new DynamicPPL PR

* mistakenly removed line

* specific constructors

* no StaticMH RWMH

* Bump bijectors compat (#2052)

* CompatHelper: bump compat for Bijectors to 0.13, (keep existing compat)

* Update Project.toml

* Replacement for #2039 (#2040)

* Fix testset for external samplers

* Update abstractmcmc.jl

* Update test/contrib/inference/abstractmcmc.jl

Co-authored-by: Tor Erlend Fjelde <[email protected]>

* Update test/contrib/inference/abstractmcmc.jl

Co-authored-by: Tor Erlend Fjelde <[email protected]>

* Update FillArrays compat to 1.4.1 (#2035)

* Update FillArrays compat to 1.4.0

* Update test compat

* Try to enable ReverseDiff tests

* Update Project.toml

* Update Project.toml

* Bump version

* Revert dependencies on FillArrays (#2042)

* Update Project.toml

* Update Project.toml

* Fix redundant definition of `getstats` (#2044)

* Fix redundant definition of `getstats`

* Update Inference.jl

* Revert "Update Inference.jl"

This reverts commit e4f51c2.

* Bump version

---------

Co-authored-by: Hong Ge <[email protected]>

* Transfer some test utility function into DynamicPPL (#2049)

* Update OptimInterface.jl

* Only run optimisation tests in numerical stage.

* fix function lookup after moving functions

---------

Co-authored-by: Xianda Sun <[email protected]>

* Move Optim support to extension (#2051)

* Move Optim support to extension

* More imports

* Update Project.toml

---------

Co-authored-by: Hong Ge <[email protected]>

---------

Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: haris organtzidis <[email protected]>
Co-authored-by: Tor Erlend Fjelde <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: Xianda Sun <[email protected]>
Co-authored-by: Cameron Pfiffer <[email protected]>

* Bugfixes.

* Add TODO.

* Update mh.jl

* Update Inference.jl

* Removed obsolete exports.

* removed unnecessary import of extract_priors

* added missing ) in MH tests

* fixed incorrect referneces to AdvancedMH in tests

* improve ESLogDensityFunction

* remove hardcoding of SimpleVarInfo

* added fixme comment

* minor style changes

* fixed issues with MH with RandomWalkProposal being used as an external sampler

* fixed accidental typo

* move definitions of unflatten for NamedTuple

* improved TODO

* Update Project.toml

---------

Co-authored-by: Hong Ge <[email protected]>
Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: haris organtzidis <[email protected]>
Co-authored-by: Tor Erlend Fjelde <[email protected]>
Co-authored-by: David Widmann <[email protected]>
Co-authored-by: Xianda Sun <[email protected]>
Co-authored-by: Cameron Pfiffer <[email protected]>
Co-authored-by: Hong Ge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants