-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement missing posterior_optima
and likelihood_optima
for a test model.
#503
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Pull Request Test Coverage Report for Build 5612537845
💛 - Coveralls |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #503 +/- ##
==========================================
- Coverage 77.22% 76.30% -0.92%
==========================================
Files 22 22
Lines 2656 2688 +32
==========================================
Hits 2051 2051
- Misses 605 637 +32
☔ View full report in Codecov by Sentry. |
TuringLang/Turing.jl#2049 is failing because the functions were moved here These are easy to fix, my concern is that we never refer to Optim interface in DynamicPPL. In my opinion, it is debatable if we should separate the Optim interface and the ground truth to test the interface. If moving the functions here while leaving everything else put is the way to go , I am happy to see this and TuringLang/Turing.jl#2049 through |
I don't have a strong preference here, but the majority of test-related functionalities for such models are in DynamicPPL. So it might be better to keep all these codes in the same place. In fact, one bug was caused by missing the |
Fix some test failures in TuringLang/Turing.jl#2018. Also, transfer some utility functions for test models from Turing to this repo.