Add missing Viridian squeaks to cutscene test menu

[InfoTeddy]

These mildly annoyed me. It should be consistent that whenever you press ACTION on a menu option, you get a Viridian squeak (at least if something happens).

Legal Stuff:

By submitting this pull request, I confirm that...

• My changes may be used in a future commercial release of VVVVVV
• I will be credited in a CONTRIBUTORS file and the "GitHub Friends"
  section of the credits for all of said releases, but will NOT be compensated
  for these changes

[Daaaav]

I don't agree - the squeaks are missing on purpose because if you have a lot of cutscenes to test, it could become annoying to hear all the squeaks. So this makes it easier to bear. Also, as a translator menu option, consistency should be less of a concern anyway.

[flibitijibibo]

It also makes me think of the earlier textbox change, and I wonder if we should start being more strict about userspace breakages - obviously we'll still have lots of editor changes but minimizing those changes for existing features may be a good idea at this point.

[Daaaav]

I don't mind userspace improvements by themselves, but people have to agree that they're improvements. :)

[TerryCavanagh]

I guess I'm very mildly with @InfoTeddy on this one, just because it's something I've noticed too. Consistency is probably good. But I usually have the game muted when I'm working on it, so I don't care that much! (sorry, this is not a useful comment)

[flibitijibibo]

I guess this would be the determining factor: If the localizers are okay with mashing the built-in mute key that would be enough to merge this, since people dealing with that screen frequently could ignore it if it becomes a problem. I'll +1/-1 whatever they decide in this case!

[InfoTeddy]

the squeaks are missing on purpose because if you have a lot of cutscenes to test, it could become annoying to hear all the squeaks.

I would just like to point out that the cutscenes themselves still have all the squeaks.

If the localizers are okay with mashing the built-in mute key that would be enough to merge this

Presumably, they are already doing this, since the cutscenes already contain squeaks.

[Daaaav]

I would just like to point out that the cutscenes themselves still have all the squeaks.

Yes, that's kind of my point - there are already so many squeaks in the cutscenes themselves that making every cutscene start with an additional squeak only adds to the pile of squeaks. And I feel you can probably get immersed in the cutscenes better if all squeaks you hear belong only to the cutscenes, and you can clearly hear when a textbox has appeared for you to read?

[flibitijibibo]

I guess to reiterate: Totally happy to let the localizers make the final call - if they say no, that's enough to block this change in favor of documenting the history of why this quirk exists.

[Daaaav]

Just gonna copy-paste this conversation here...

Update:

And for completeness, the comparison videos:

2024-01-22_21-12-31.mp4

2024-01-22_21-15-53.mp4

---

For what it's worth, I'm one of the localizers myself so my personal vote would be for no, but not because I remember what the experience was actually like. Maybe it doesn't matter that much, though.