Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nitpicks #589

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Nitpicks #589

merged 3 commits into from
Oct 12, 2023

Commits on Oct 11, 2023

  1. Compiler nitpick 

    Reported by:	clang-16
    @gperciva
    gperciva committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    4b0713f View commit details
    Browse the repository at this point in the history

  2. comment: clarify crypto_MGF1()

    @gperciva
    gperciva committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    2a196db View commit details
    Browse the repository at this point in the history

  3. Add headers 

    Also, fix the alphabetical order of headers in tar/storage/storage_read_cache.h.

../keygen/keygen_network.c should add these lines:
  #include "crypto.h"        // for crypto_hash_data, crypto_hash_data_...

../lib/crypto/crypto_compat.c should add these lines:
  #include <openssl/crypto.h>    // for CRYPTO_cleanup_all_ex_data

../tar/chunks/chunks_write.c should add these lines:
  #include "storage.h"       // for storage_write_file, STORAGE_W

../tar/multitape/multitape_metadata.c should add these lines:
  #include "chunks.h"        // for CHUNKS_S, chunks_delete_extrastats

../tar/multitape/multitape_metaindex.c should add these lines:
  #include "chunks.h"        // for chunks_delete_extrastats, chunks_st...
  #include "storage.h"       // for storage_delete_file, storage_read_file

../tar/multitape/multitape_recover.c should add these lines:
  #include "storage.h"       // for storage_transaction_commitfromcheckp...

../tar/storage/storage_delete.c should add these lines:
  #include "tsnetwork.h"     // for network_select, NETWORK_STATUS_OK

../tar/storage/storage_directory.c should add these lines:
  #include "tsnetwork.h"     // for network_spin, NETWORK_STATUS_OK

../tar/storage/storage_read.c should add these lines:
  #include "tsnetwork.h"     // for network_spin, NETWORK_STATUS_OK

../tar/storage/storage_read_cache.c should add these lines:
  #include "storage.h"       // for timeval

../tar/storage/storage_transaction.c should add these lines:
  #include "tsnetwork.h"     // for network_spin, NETWORK_STATUS_OK

../tar/storage/storage_write.c should add these lines:
  #include "tsnetwork.h"     // for network_select, network_spin, NETWORK_...

Reported by:	include-what-you-use 0.20
    @gperciva
    gperciva committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    9d35926 View commit details
    Browse the repository at this point in the history