Nitpicks #589
Merged
Nitpicks #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported by: clang-16
Also, fix the alphabetical order of headers in tar/storage/storage_read_cache.h. ../keygen/keygen_network.c should add these lines: #include "crypto.h" // for crypto_hash_data, crypto_hash_data_... ../lib/crypto/crypto_compat.c should add these lines: #include <openssl/crypto.h> // for CRYPTO_cleanup_all_ex_data ../tar/chunks/chunks_write.c should add these lines: #include "storage.h" // for storage_write_file, STORAGE_W ../tar/multitape/multitape_metadata.c should add these lines: #include "chunks.h" // for CHUNKS_S, chunks_delete_extrastats ../tar/multitape/multitape_metaindex.c should add these lines: #include "chunks.h" // for chunks_delete_extrastats, chunks_st... #include "storage.h" // for storage_delete_file, storage_read_file ../tar/multitape/multitape_recover.c should add these lines: #include "storage.h" // for storage_transaction_commitfromcheckp... ../tar/storage/storage_delete.c should add these lines: #include "tsnetwork.h" // for network_select, NETWORK_STATUS_OK ../tar/storage/storage_directory.c should add these lines: #include "tsnetwork.h" // for network_spin, NETWORK_STATUS_OK ../tar/storage/storage_read.c should add these lines: #include "tsnetwork.h" // for network_spin, NETWORK_STATUS_OK ../tar/storage/storage_read_cache.c should add these lines: #include "storage.h" // for timeval ../tar/storage/storage_transaction.c should add these lines: #include "tsnetwork.h" // for network_spin, NETWORK_STATUS_OK ../tar/storage/storage_write.c should add these lines: #include "tsnetwork.h" // for network_select, network_spin, NETWORK_... Reported by: include-what-you-use 0.20
gperciva
commented
Oct 11, 2023
| @@ -93,7 +93,8 @@ int crypto_file_init_keys(void); | |||
|
|
|||
| /** | |||
| * crypto_MGF1(seed, seedlen, buf, buflen): | |||
| * The MGF1 mask generation function, as specified in RFC 3447. | |||
| * The MGF1 mask generation function, as specified in RFC 3447 section B.2.1, | |||
There was a problem hiding this comment.
I've had this change laying around for over a year, but it never seemed important enough to include it in a PR.
I forget why I was looking up the details of it, but when I found the right section, it occurred to me that being a bit more specific in the API comment would have saved me some time.
https://datatracker.ietf.org/doc/html/rfc3447#appendix-B.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.