Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updateed the description of Chinese sky culture and fixed some issues. #1952

Merged
merged 71 commits into from
Oct 5, 2021

Conversation

sunshuwei
Copy link
Contributor

Description

Fixed some incorrect stars in Chinese sky culture.
Update description file.
Modify the names of the two walls of Three Enclosures in the Chinese medieval sky culture. According to records, in the Middle Ages, they were more called "East Wall" and "West Wall" rather than "Left Wall" and "Right Wall".

Fixes # (issue)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • Operating system: <Name, version number>
  • Graphics Card: <Manufacturer (likely Intel, NVidia, AMD?), Model (HD, Geforce, Radeon..., with model number), driver version?>

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

Great PR! Please pay attention to the following items before merging:

Files matching skycultures/**:

  • Did you remember to update po/stellarium-skycultures/POFILES.in and src/translations.h files respectively to changes in sky cultures?
  • Did you remember to update skycultures/CMakeLists.txt and skycultures/YOUR-SKYCULTURE-FOLDER/CMakeLists.txt files respectively to changes in sky cultures?
  • Did you remember to update util/skycultures/po4a.config file respectively to changes in sky cultures?
  • Did you remember to define classification parameter in sky cultures?

This is an automatically generated QA checklist based on modified files

Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for updating the sky cultures

@alex-w alex-w added this to the 0.21.3 milestone Oct 4, 2021
@alex-w alex-w merged commit 16f56f0 into Stellarium:master Oct 5, 2021
@alex-w alex-w added enhancement Improve existing functionality description Improvements or additions to description of scenery, landscape or skyculture… and removed enhancement Improve existing functionality labels Oct 5, 2021
@github-actions
Copy link

github-actions bot commented Oct 5, 2021

Hello @sunshuwei! Thank you for this enhancement.

@github-actions
Copy link

Hello @sunshuwei! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@github-actions
Copy link

Hello @sunshuwei! Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

@alex-w alex-w added the purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
description Improvements or additions to description of scenery, landscape or skyculture… purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes
Development

Successfully merging this pull request may close these issues.

2 participants