Some small fixes to Chinese skyculture and Chinese contemporary skycu… #1721
Conversation
…lture,updated Bayer designations and Flamsteed designations of the stars,updated Chinese translation of skycultures.
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,5 +1,4 @@ | |||
| 677|α_And | |||
| 841|22_And | |||
There was a problem hiding this comment.
HIP 841 = 22 And according to SIMBAD
| @@ -84,6 +84,7 @@ | |||
| 10176|59_And_A | |||
| 10180|59_And_B | |||
| 10340|60_And | |||
| 10805|61_And* | |||
There was a problem hiding this comment.
Why asterisk added here?
HIP 10805 = 61 And according to SIMBAD
There was a problem hiding this comment.
| 10805|61_And* | |
| 10805|61_And* |
according to V520_Persei and
Table of stars with Flamsteed designations
There was a problem hiding this comment.
Where you see asterisk for 61 And? Just for note: asterisk and double asterisk in SIMBAD are not part of star designation, but this is part of SIMBAD designations, meaning star and double star respectively.
| 113136|76_Aqr | ||
| 113148|77_Aqr | ||
| 113127|78_Aqr | ||
| 113686|80_Aqr? |
There was a problem hiding this comment.
According to SIMBAD this star hasn’t Flamesteed or Bayer designation. Where is source for it?
There was a problem hiding this comment.
| 113686|80_Aqr? | |
| 113686|80_Aqr? |
according to Table of stars with Flamsteed designations
There was a problem hiding this comment.
In Wikipedia you may see that designation 80 Aqr maybe associated to HIP 113686.
There was a problem hiding this comment.
Please do not draw from all possible sources without giving references. A Wikipedia list without source is not good. I see "HD217563?" which further refers to HIP113686. But it's unclear who made the identification.
@alex-w I just noted name.fab is not described in Appendix C. We should add a section with guidelines and rules. Do you know all the sources for this list?
There was a problem hiding this comment.
@gzotti this list created according to few catalogs, I don’t remember all sources
| @@ -1247,12 +1377,15 @@ | |||
| 7450|50_Cet | |||
| 8102|52_Cet | |||
| 8497|53_Cet | |||
| 8588|54_Cet* | |||
| 12107|80_Cet | ||
| 12247|81_Cet | ||
| 12387|82_Cet | ||
| 12390|83_Cet | ||
| 12530|84_Cet | ||
| 12647|85_Cet* |
| 12706|86_Cet | ||
| 12828|87_Cet | ||
| 12832|88_Cet* |
There was a problem hiding this comment.
According to 38_Ari and Table of stars with Flamsteed designations
There was a problem hiding this comment.
This star hasn’t asterisk in designation
| @@ -1309,6 +1448,7 @@ | |||
| 27628|β_Col | |||
| 28199|γ_Col | |||
| 30277|δ_Col | |||
| 30277|3_CMa* | |||
There was a problem hiding this comment.
according to δ Col and Table of stars with Flamsteed designations
There was a problem hiding this comment.
This star hasn’t asterisk in designation!
| @@ -1360,6 +1502,7 @@ | |||
| 62886|35_Com | |||
| 63355|36_Com | |||
| 63462|37_Com | |||
| 63462|13_CVn* | |||
There was a problem hiding this comment.
| 63462|13_CVn* | |
| 63462|13_CVn* |
According to 37_Com and Table of stars with Flamsteed designations
There was a problem hiding this comment.
This star hasn’t asterisk in designation
|
@sunshuwei please check the Chinese part of PR |
| @@ -1449,19 +1592,29 @@ | |||
| 56802|ι_Crt | |||
| 55874|κ_Crt | |||
| 55598|λ_Crt | |||
| 54742|ψ_Crt | |||
| 53037|5_Crt* | |||
| 53740|7_Crt | ||
| 53963|8_Crt* |
| 53740|7_Crt | ||
| 53963|8_Crt* | ||
| 54477|10_Crt* |
| 54682|11_Crt | ||
| 55282|12_Crt | ||
| 55598|13_Crt | ||
| 55687|14_Crt | ||
| 55705|15_Crt | ||
| 55874|16_Crt | ||
| 56280|17_Crt | ||
| 56280|17_Crt* |
| @@ -4252,6 +4670,7 @@ | |||
| 67231|84_UMa | |||
| 67301|85_UMa | |||
| 67848|86_UMa | |||
| 67627|87_UMa* | |||
| 11767|1_UMi | ||
| 5372|2_UMi | ||
| 5372|2_UMi* |
| 61941|29_Vir | ||
| 61960|30_Vir | ||
| 61968|31_Vir | ||
| 62267|32_Vir | ||
| 62325|33_Vir | ||
| 62394|34_Vir | ||
| 62443|35_Vir | ||
| 62541|36_Vir* |
| 69427|98_Vir | ||
| 69701|99_Vir | ||
| 69974|100_Vir | ||
| 69829|101_Vir* |
| @@ -4506,6 +4950,7 @@ | |||
| 103004|31_Vul | |||
| 103200|32_Vul | |||
| 103511|33_Vul | |||
| 105411|34_Vul* | |||
There was a problem hiding this comment.
I agree with @alex-w that @sunshuwei, who provided a very extensive description, should please review this. Mixing sources may be problematic to begin with. (The "western" is a special case and permanent working zone...) I would prefer to have exactly one source book (or more if they agree on the figures) implemented accurately, else this becomes a hodge-podge where always one or somebody else will "fix" something "corrected" recently by somebody else.
|
Please remove asterisk from designations, because this file contains modern designations. |
|
Important note: all *.po files will be replaced by translations from Transifex! |
|
@lvhaocheng Please extract all related to western skyculture stuff into separate pull request. |
|
I will modify it later. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
I've checked |
|
@sunshuwei please check the Chinese part of PR @lvhaocheng any news for resolving conflicts and changes in the PR? |
OK |
|
I think it's good for me. |
|
I noticed that these are double stars indistinguishable by naked eye. |
|
They are each a member of a double star. Hundreds of years ago, astronomy officials used the naked eye to determine the names of stars. |
|
OK, in this case it may be useful to assign the name to the brighter of the pair. Else the screen is cluttered with too much text. |
Yes, I think so. |
|
I fixed some of them, others are open for discussion. |
alex-w
added
the
purpose: cultural astronomy
Some small fixes to skycultures and star names
Description
中西对照恒星图表1950.0(星表分册)) and The History of Stellar Observation in China (Chinese:中国恒星观测史).中西对照恒星图表1950.0(星表分册)) and The History of Stellar Observation in China (Chinese:中国恒星观测史).Fixes # (issue)
Some small fixes to Chinese skyculture:
constellationship.fab:description.zh_CN.utf8,description.zh_HK.utf8anddescription.zh_TW.utf8star_names.fabandstar_names.zh_CN.fab:Some small fixes to Chinese Contemporary skyculture:
star_names.fab:asterism_lines.fab, fixed lines of Xingguans:Some small fixes to Western skyculture:
star_names.fab, fixed HIP 42080 "Althiba I"In
stellarium/stars/default/name.fab, updated Bayer designations and Flamsteed designations of the stars according to Wikipedia and Simbad, such as "c1_Cap", "6_Cnc*" and many othersIn
stellarium/po/stellarium-skycultures/zh_CN.po, fixed some small problems to Chinese translation of skycultures.Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: