Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Set mv insert overwrite job enableInsertStrict to false (backport #33643) #44820

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 26, 2024

Fixes #issue
set seesion variable enableInsertStrict to false.
eg.
if base table has partition [2020-07-15, 2020-08-15),
mv has partition [2020-08-01, 2020-09-01), mv need to insert from base table data which partition value at [2020-01-01, 2020-08-15)

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #33643 done by [Mergify](https://mergify.com). Fixes #issue set seesion variable enableInsertStrict to false. eg. if base table has partition [2020-07-15, 2020-08-15), mv has partition [2020-08-01, 2020-09-01), mv need to insert from base table data which partition value at [2020-01-01, 2020-08-15)

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

)

Signed-off-by: Youngwb <[email protected]>
(cherry picked from commit 1db05ef)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java
@mergify mergify bot added the conflicts label Apr 26, 2024
Copy link
Contributor Author

mergify bot commented Apr 26, 2024

Cherry-pick of 1db05ef has failed:

On branch mergify/bp/branch-2.5/pr-33643
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit 1db05ef031.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Apr 26, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

auto-merge was automatically disabled April 26, 2024 07:44

Pull request was closed

@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-33643 branch April 26, 2024 07:44
@LiShuMing LiShuMing restored the mergify/bp/branch-2.5/pr-33643 branch April 26, 2024 07:53
@LiShuMing LiShuMing reopened this Apr 26, 2024
Signed-off-by: shuming.li <[email protected]>
@LiShuMing LiShuMing enabled auto-merge (squash) April 26, 2024 11:14
@andyziye andyziye disabled auto-merge April 26, 2024 11:23
@andyziye andyziye merged commit bafceb4 into branch-2.5 Apr 26, 2024
48 of 53 checks passed
@andyziye andyziye deleted the mergify/bp/branch-2.5/pr-33643 branch April 26, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants