Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Set mv insert overwrite job enableInsertStrict to false #33643

Merged
merged 1 commit into from
Oct 25, 2023
Merged

[BugFix] Set mv insert overwrite job enableInsertStrict to false #33643

merged 1 commit into from
Oct 25, 2023

Conversation

Youngwb
Copy link
Contributor

@Youngwb Youngwb commented Oct 25, 2023 •
edited
Loading

Fixes #issue
set seesion variable enableInsertStrict to false.
eg.
if base table has partition [2020-07-15, 2020-08-15),
mv has partition [2020-08-01, 2020-09-01), mv need to insert from base table data which partition value at [2020-01-01, 2020-08-15)

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@github-actions github-actions bot added the 3.2 label Oct 25, 2023
@github-actions github-actions bot added the 3.1 label Oct 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java 1 1 100.00% []

@github-actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@ABingHuang ABingHuang enabled auto-merge (squash) October 25, 2023 11:06
@ABingHuang ABingHuang merged commit 1db05ef into StarRocks:main Oct 25, 2023
49 of 50 checks passed
@github-actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Oct 25, 2023
@github-actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Oct 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 25, 2023
@Youngwb @mergify
[BugFix] Set mv insert overwrite job enableInsertStrict to false (#33643
7fd9c41 
)

Signed-off-by: Youngwb <[email protected]>
(cherry picked from commit 1db05ef)
@mergify mergify bot mentioned this pull request Oct 25, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 25, 2023
@Youngwb @mergify
[BugFix] Set mv insert overwrite job enableInsertStrict to false (#33643
efdbaa4 
)

Signed-off-by: Youngwb <[email protected]>
(cherry picked from commit 1db05ef)
@mergify mergify bot mentioned this pull request Oct 25, 2023
Merged
@Youngwb Youngwb deleted the mv_insert_strict branch October 25, 2023 11:56
wanpengfei-git pushed a commit that referenced this pull request Oct 25, 2023
@Youngwb @wanpengfei-git
[BugFix] Set mv insert overwrite job enableInsertStrict to false (#33643
a8c2a7c 
)

Signed-off-by: Youngwb <[email protected]>
(cherry picked from commit 1db05ef)
wanpengfei-git pushed a commit that referenced this pull request Oct 25, 2023
@Youngwb @wanpengfei-git
[BugFix] Set mv insert overwrite job enableInsertStrict to false (#33643
eca653a 
)

Signed-off-by: Youngwb <[email protected]>
(cherry picked from commit 1db05ef)
ABingHuang pushed a commit to ABingHuang/starrocks that referenced this pull request Oct 31, 2023
@Youngwb @ABingHuang
[BugFix] Set mv insert overwrite job enableInsertStrict to false (Sta…
460a470 
…rRocks#33643)

Signed-off-by: Youngwb <[email protected]>
(cherry picked from commit 1db05ef)
@LiShuMing
Copy link
Contributor

@mergify backport branch-2.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 26, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 26, 2024
@Youngwb @mergify
[BugFix] Set mv insert overwrite job enableInsertStrict to false (#33643
b6ef52a 
)

Signed-off-by: Youngwb <[email protected]>
(cherry picked from commit 1db05ef)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java
@mergify mergify bot mentioned this pull request Apr 26, 2024
Merged
39 tasks
andyziye pushed a commit that referenced this pull request Apr 26, 2024
@mergify
[BugFix] Set mv insert overwrite job enableInsertStrict to false (bac…
bafceb4 
…kport #33643) (#44820)

Signed-off-by: shuming.li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murphyatwork murphyatwork murphyatwork approved these changes

@ABingHuang ABingHuang ABingHuang approved these changes

Assignees

@Youngwb Youngwb

Labels
2.5-merged backport_ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Youngwb @LiShuMing @murphyatwork @ABingHuang @wanpengfei-git