Verify that channel exists when validating outbound message #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair-singh
force-pushed
the
check-channel-in-outbound-queue
branch
from
3febd4b
to
83650f2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1067 +/- ##
==========================================
+ Coverage 80.55% 80.57% +0.02%
==========================================
Files 55 55
Lines 2273 2276 +3
Branches 71 71
==========================================
+ Hits 1831 1834 +3
Misses 425 425
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| }); | ||
| } | ||
|
|
||
| pub fn send_transfer_token_message_insufficient_fund<Runtime, XcmConfig>( |
There was a problem hiding this comment.
Why do we remove this test?
There was a problem hiding this comment.
This is a test utility that's called from multiple tests, not a test itself. This was duplicated for each test case and I refactored it into a single test utility that allows you to specify fees and the error you expect.
alistair-singh
force-pushed
the
check-channel-in-outbound-queue
branch
from
ad08d11
to
cca88bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polkadot-sdk: Snowfork/polkadot-sdk#73
This is a simpler version of #1047
Fixes: SNO-771