This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Check channel in outbound queue #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claravanstaden
approved these changes
Dec 19, 2023
vgeddes
reviewed
Dec 19, 2023
| @@ -22,6 +22,7 @@ use emulated_integration_tests_common::{ | |||
| }; | |||
| use parachains_common::Balance; | |||
|
|
|||
| pub const ASSETHUB_PARA_ID: u32 = 1000; | |||
There was a problem hiding this comment.
Can we use AssetHubRococo::para_id() here?
Also perhaps the BridgeHub PARA_ID is also available in some constant provided by the bridges team
There was a problem hiding this comment.
It would require adding more dependencies. If this is out of date, the tests will fail. So I think it's simpler and protected against change.
vgeddes
approved these changes
Dec 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snowbridge: Snowfork/snowbridge#1067