Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iOS support #757

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Add iOS support #757

wants to merge 31 commits into from

Conversation

ImUrX
Copy link
Member

@ImUrX ImUrX commented Jul 3, 2023 •
edited
Loading

Blocked by #756

To-do list

  • make the subproject an iOS library instead of an app
  • add iOS target to Tauri
  • import the subproject library inside Tauri

@ImUrX ImUrX added Status: Blocked by other issue Progress cannot be made until linked issue is resolved Type: Enhancement Adds or improves a feature Area: Server Related to the server labels Jul 3, 2023
@TheButlah
Copy link
Contributor

TheButlah commented Jul 3, 2023 •
edited
Loading

This PR is impossible to review, because its not clear what is a mechanical refactor, and what is new custom stuff.
If you are moving/refactoring etc, I'd do that in a PR first, merge it, and then make a second PR that adds the ios stuff. Just my 2 cents, I'm not your reviewer anyway :3

@ImUrX
Copy link
Member Author

ImUrX commented Jul 3, 2023

i would target each branch on each PR to make them readable, but what I wanted to transmit with these is that I have multiple branches waiting on #727

@ImUrX
Copy link
Member Author

ImUrX commented Jul 3, 2023 •
edited
Loading

and well I cant even target each branch on each PR because they are in my repo's branches not in here :/

(btw I'm planning to rebase each time one of the PR gets merged)

@ImUrX ImUrX force-pushed the ios-subproject branch 3 times, most recently from e3c34ec to 2eec3e2 Compare July 14, 2023 20:20
@ImUrX ImUrX removed the Status: Blocked by other issue Progress cannot be made until linked issue is resolved label Jul 30, 2023
@ImUrX ImUrX added the OS: iOS Operating system: iOS label Jul 30, 2023
ButterscotchV
ButterscotchV approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@ButterscotchV ButterscotchV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright, if it tests fine then I'd say it's good (I can't test it myself, no Apple).

server/core/build.gradle.kts
Comment on lines +57 to +58
implementation("com.fasterxml.jackson.core:jackson-databind:2.13.5")
implementation("com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:2.13.5")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the rollback in version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i dmed you about this, its the use of some reflection that robovm didnt support

@9il
Copy link
Contributor

9il commented Apr 14, 2024

Hi, I would love to have iOS SlimeVR Server. I though it is impossible or very complicated because of JVM.

Don't we need JVM for the server? If so, how it can run on iOS then?

@ImUrX
Copy link
Member Author

ImUrX commented Apr 15, 2024

its compiled to iOS native via RoboVM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ButterscotchV ButterscotchV ButterscotchV approved these changes

@loucass003 loucass003 Awaiting requested review from loucass003 loucass003 is a code owner

@Erimelowo Erimelowo Awaiting requested review from Erimelowo Erimelowo is a code owner

@Eirenliel Eirenliel Awaiting requested review from Eirenliel Eirenliel is a code owner

@TheButlah TheButlah Awaiting requested review from TheButlah

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Area: Server Related to the server OS: iOS Operating system: iOS Type: Enhancement Adds or improves a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ImUrX @TheButlah @9il @ButterscotchV