Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing identifier to SearchInputSummary #2077

Merged
merged 1 commit into from
Oct 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ public struct BPKSearchInputSummary: View {
private let placeholder: String
private let inputPrefix: InputPrefix?
private var style: Style = .default
private let accessibilityIdentifier: String
private var customAccessibilityValue: String?
private let readOnly: Bool
private let clearAction: ClearAction
Expand All @@ -57,13 +58,15 @@ public struct BPKSearchInputSummary: View {
inputPrefix: InputPrefix? = nil,
clearAction: ClearAction,
readOnly: Bool = false,
accessibilityIdentifier: String = "search_field",
customAccessibilityValue: String? = nil,
_ text: Binding<String>
) {
self.placeholder = placeholder
self.inputPrefix = inputPrefix
self.clearAction = clearAction
self.readOnly = readOnly
self.accessibilityIdentifier = accessibilityIdentifier
self.customAccessibilityValue = customAccessibilityValue
self._text = text
}
Expand All @@ -82,6 +85,7 @@ public struct BPKSearchInputSummary: View {
.accessibilityValue(customAccessibilityValue ?? text)
.accessibilityLabel(placeholder)
.accessibilityAddTraits(readOnly ? [] : .isSearchField)
.accessibilityIdentifier(accessibilityIdentifier)
.focused($focused)
accessory
}
Expand Down
Loading