Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing identifier to SearchInputSummary #2077

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

novinfard
Copy link
Contributor

An accessibility identifier required for the automated test has been removed in the following PR:
https://github.com/Skyscanner/backpack-ios/pull/2066/files#diff-0df197ad1c29c184f5dab226161c3658be5fdfffc53bb83d23529f1863aa1300L68

This PR purpose is to bring it back and fix the testing pipeline.

Remember to include the following changes:

If you are curious about how we review, please read through the code review guidelines

@xo0ps xo0ps merged commit 3f88778 into main Oct 8, 2024
14 of 16 checks passed
@xo0ps xo0ps deleted the donburi/no-jira-fix-missing-accessibility-identifier branch October 8, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Non breaking change swiftui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants