Merge pull request #372 from Shopify/rwstauner/make-too-clean

Stop calling make clean after configuring
Shopify · Dec 7, 2024 · edabab7 · edabab7
2 parents a736502 + c7567d1
commit edabab7
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/yjit_metrics/repo_management.rb b/lib/yjit_metrics/repo_management.rb
@@ -58,7 +58,9 @@ def clone_ruby_repo_with(path:, git_url:, git_branch:, config_opts:, config_env:
 
         if should_configure
           check_call("#{config_env.join(" ")} ./configure #{ config_opts.join(" ") }")
-          check_call("make clean")
+          # make clean is currently removing too much, but we don't need it when
+          # we call `git clean` prior to this.
+          # check_call("make clean")
         end
 
         check_call("make -j16")