Skip to content

Commit

Permalink
Stop calling make clean after configuring
Browse files Browse the repository at this point in the history
We already call git clean prior to this.
The make clean is removing needed files due to a change in CRuby:
https://github.com/ruby/ruby/pull/12212/files#r1874543682
  • Loading branch information
rwstauner committed Dec 7, 2024
1 parent a736502 commit c7567d1
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion lib/yjit_metrics/repo_management.rb
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ def clone_ruby_repo_with(path:, git_url:, git_branch:, config_opts:, config_env:

if should_configure
check_call("#{config_env.join(" ")} ./configure #{ config_opts.join(" ") }")
check_call("make clean")
# make clean is currently removing too much, but we don't need it when
# we call `git clean` prior to this.
# check_call("make clean")
end

check_call("make -j16")
Expand Down

0 comments on commit c7567d1

Please sign in to comment.