Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rtl client #2026

Open
wants to merge 183 commits into
base: master
Choose a base branch
from
Open

Rtl client #2026

wants to merge 183 commits into from

Commits on Mar 7, 2024

  1. feat(get texts): functions for getting texts from api-v3 and modifyin… 

    …g them to fit the expected old api response.
    @YishaiGlasner
    YishaiGlasner committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    af16bd8 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2024

  1. doc(get texts): todo strings.

    @YishaiGlasner
    YishaiGlasner committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    22591ec View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. refactor(currVersions): this refactor changes the currVersions object… 

    … to include an object for any language (he and en) rather than a string. The idea is to enable it to include other details and not only versionTitle.
    @YishaiGlasner
    YishaiGlasner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    5b2aa35 View commit details
    Browse the repository at this point in the history

  2. chore(currVersions): remove console logs.

    @YishaiGlasner
    YishaiGlasner committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    5e8ba29 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Merge branch 'currVersions' into rtl

    @YishaiGlasner
    YishaiGlasner committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    e170816 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. Merge branch 'master' into rtl

    @YishaiGlasner
    YishaiGlasner committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    488a216 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. feat(translations): use the v3 functions for getting texts in compone… 

    …nts.
    @YishaiGlasner
    YishaiGlasner committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1b9b883 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. feat(url): insert languageFamilyName to url.

    @YishaiGlasner
    YishaiGlasner committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    f726d21 View commit details
    Browse the repository at this point in the history

  2. feat(url): redirect old urls.

    @YishaiGlasner
    YishaiGlasner committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    000394c View commit details
    Browse the repository at this point in the history

  3. refactor(TextRange): rename handleResize to conditionalPlaceSegmentNu… 

    …mbers and use it rather than placeSegmentNuncers.
    @YishaiGlasner
    YishaiGlasner committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    ee70e1f View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. feat(translations): use text-v3 in work (commit for pushing for worki… 

    …ng together).
    @YishaiGlasner
    YishaiGlasner committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    4f32748 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. fix(TextRange): do not change ref for link to segment.

    @YishaiGlasner
    YishaiGlasner committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    182b2b4 View commit details
    Browse the repository at this point in the history

  2. chore(TextRange): remove console.logs.

    @YishaiGlasner
    YishaiGlasner committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    aa89537 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2024

  1. feat(ReaderControls): use the new function for getting text.

    @YishaiGlasner
    YishaiGlasner committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    a36c7b8 View commit details
    Browse the repository at this point in the history

  2. feat(get texts): add 'sources' and 'heSources' to adapted response.

    @YishaiGlasner
    YishaiGlasner committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    1a2d6e1 View commit details
    Browse the repository at this point in the history

  3. refactor(ReaderControls): use data for determining what translation t… 

    …itle should be displayed.
    @YishaiGlasner
    YishaiGlasner committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    587e628 View commit details
    Browse the repository at this point in the history

  4. refactor(currVersions): remove APIResult attributes which are not in … 

    …use anymore.
    @YishaiGlasner
    YishaiGlasner committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    7627be5 View commit details
    Browse the repository at this point in the history

  5. fix(getting texts): add the attributes sources and heSources only whe… 

    …n there is more than one source.
    @YishaiGlasner
    YishaiGlasner committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    b27423c View commit details
    Browse the repository at this point in the history

  6. fix(getting texts): add the attributes sources and heSources only whe… 

    …n the aources attribute is in the response.
    @YishaiGlasner
    YishaiGlasner committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    c182498 View commit details
    Browse the repository at this point in the history

  7. fix(SSR): assign an empty array to he/text when there is no source/tr… 

    …anslation.
    @YishaiGlasner
    YishaiGlasner committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    d787953 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. refactor(ReaderPanel): get data directly with asking it and pass it t… 

    …o components (rather than get it from cache objects).
    @YishaiGlasner
    YishaiGlasner committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    018cc74 View commit details
    Browse the repository at this point in the history

  2. chore: fix a git accident.

    @YishaiGlasner
    YishaiGlasner committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    aaf985e View commit details
    Browse the repository at this point in the history

  3. refactor(ReaderPanel): rename conditionalSetData to conditionalSetTex… 

    …tData.
    @YishaiGlasner
    YishaiGlasner committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    f46619f View commit details
    Browse the repository at this point in the history

  4. fix(ReaderPanel): don't try to get things from data when it's null.

    @YishaiGlasner
    YishaiGlasner committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d23db3f View commit details
    Browse the repository at this point in the history

  5. fix(ReaderPanel): set translation in ReaderControls when it gots data.

    @YishaiGlasner
    YishaiGlasner committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    76c25e1 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. fix(ReaderPanel): fix the flowing of tata into ReaderControl and maki… 

    …ng the translation VersionTitle.
    @YishaiGlasner
    YishaiGlasner committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    8bf5e77 View commit details
    Browse the repository at this point in the history

  2. refactor(ReaderPanel): function for comparing both currVersions.

    @YishaiGlasner
    YishaiGlasner committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    cb80ac5 View commit details
    Browse the repository at this point in the history

  3. fix(SSR processing): save the versions according to the new api retur… 

    …ned object in ssr processing.
    @YishaiGlasner
    YishaiGlasner committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    10e14f0 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. feat(texts): css for rtl as translation and ltr as source.

    @YishaiGlasner
    YishaiGlasner committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    43cb1bf View commit details
    Browse the repository at this point in the history

  2. fix(translations): show currently selected for rtl translations.

    @YishaiGlasner
    YishaiGlasner committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    9c2e835 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. fix(texts): show only the source/translation when this is selected.

    @YishaiGlasner
    YishaiGlasner committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    3d2ab03 View commit details
    Browse the repository at this point in the history

  2. fix(texts): show only the source/translation when this is selected.

    @YishaiGlasner
    YishaiGlasner committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    ad255e5 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. feat(texts menu): new text menu (with only language button for this PR). 

    also remove the cases of 'text toc' and 'sheet meta' for ReaderPanel menuOpen mode, and some other garbage.
    @YishaiGlasner
    YishaiGlasner committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    b5e6172 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into rtl

    @YishaiGlasner
    YishaiGlasner committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    638fcd1 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. feat(texts menu): add layout options to menu.

    @YishaiGlasner
    YishaiGlasner committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2e898ab View commit details
    Browse the repository at this point in the history

  2. feat(texts menu): svg layout files.

    @YishaiGlasner
    YishaiGlasner committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    0f4bc63 View commit details
    Browse the repository at this point in the history

  3. fix(texts menu): handle cases where data is not loaded yet.

    @YishaiGlasner
    YishaiGlasner committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    af741ed View commit details
    Browse the repository at this point in the history

  4. fix(texts menu): location of the wotd in menu.

    @YishaiGlasner
    YishaiGlasner committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    5347781 View commit details
    Browse the repository at this point in the history

  5. fix(texts menu): show only language toggle in compare panel.

    @YishaiGlasner
    YishaiGlasner committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    4b12c96 View commit details
    Browse the repository at this point in the history

  6. feat(texts menu): add border line.

    @YishaiGlasner
    YishaiGlasner committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    4dd2d27 View commit details
    Browse the repository at this point in the history

  7. fix(texts menu): layout direction.

    @YishaiGlasner
    YishaiGlasner committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    0713324 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. fix(texts menu): popover menu direction.

    @YishaiGlasner
    YishaiGlasner committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    69b6fbc View commit details
    Browse the repository at this point in the history

  2. feat(texts menu): layout icon for stacked ltr rtl.

    @YishaiGlasner
    YishaiGlasner committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    2a1726b View commit details
    Browse the repository at this point in the history

  3. fix(texts menu): switch layout icons for mono text.

    @YishaiGlasner
    YishaiGlasner committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d47135f View commit details
    Browse the repository at this point in the history

  4. fix(texts): direction for mono text.

    @YishaiGlasner
    YishaiGlasner committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    47ecdcc View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. fix(texts): direction for bilingual when primary is ltr and translati… 

    …on rtl.
    @YishaiGlasner
    YishaiGlasner committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    14d507f View commit details
    Browse the repository at this point in the history

  2. feat(texts): Hebrew strings for 'Translation' and 'Source with Transl… 

    …ation'.
    @YishaiGlasner
    YishaiGlasner committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    3414b13 View commit details
    Browse the repository at this point in the history

  3. fix(texts): svgs with the right names.

    @YishaiGlasner
    YishaiGlasner committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    49bde51 View commit details
    Browse the repository at this point in the history

  4. feat(text meny): font size buttons.

    @YishaiGlasner
    YishaiGlasner committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    221c1dd View commit details
    Browse the repository at this point in the history

  5. feat(text meny): aliyot toggle switch.

    @YishaiGlasner
    YishaiGlasner committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    27e5f5d View commit details
    Browse the repository at this point in the history

  6. fix(text menu): font size buttons order in Hebrew interface.

    @YishaiGlasner
    YishaiGlasner committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    06c79e2 View commit details
    Browse the repository at this point in the history

  7. feat(text menu): vowels and cantillation toggles.

    @YishaiGlasner
    YishaiGlasner committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    e16690d View commit details
    Browse the repository at this point in the history

  8. feat(text menu): punctuation toggle.

    @YishaiGlasner
    YishaiGlasner committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    e004f9a View commit details
    Browse the repository at this point in the history

  9. refactor(text menu): do all toggles in the same format.

    @YishaiGlasner
    YishaiGlasner committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    b129bb6 View commit details
    Browse the repository at this point in the history

  10. feat(text menu): Hebrew string for cantillation.

    @YishaiGlasner
    YishaiGlasner committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    7ae7c9d View commit details
    Browse the repository at this point in the history

  11. refactor(text menu): remove old ReaderDisplayOptionsMenu.

    @YishaiGlasner
    YishaiGlasner committed Apr 21, 2024
    Configuration menu
    Copy the full SHA
    586e609 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. feat(reader panel): gray and margins for translation in stacked layout.

    @YishaiGlasner
    YishaiGlasner committed May 1, 2024
    Configuration menu
    Copy the full SHA
    2011261 View commit details
    Browse the repository at this point in the history

  2. feat(text menu): cursor pointer for buttons.

    @YishaiGlasner
    YishaiGlasner committed May 1, 2024
    Configuration menu
    Copy the full SHA
    ceb4fa1 View commit details
    Browse the repository at this point in the history

  3. feat(texts client): 'empty' text as translation when the api response… 

    … has only one text.
    @YishaiGlasner
    YishaiGlasner committed May 1, 2024
    Configuration menu
    Copy the full SHA
    8c795d7 View commit details
    Browse the repository at this point in the history

  4. doc(texts client): remove todo.

    @YishaiGlasner
    YishaiGlasner committed May 1, 2024
    Configuration menu
    Copy the full SHA
    00f30e2 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. feat(texts): show only one text when there is only one on bilingual s… 

    …tate.
    @YishaiGlasner
    YishaiGlasner committed May 5, 2024
    Configuration menu
    Copy the full SHA
    72dbe19 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. feat(texts): show titles and other content-related texts in the conte… 

    …nt language if it's hebrew or english and in the interdace language otherwise.
    @YishaiGlasner
    YishaiGlasner committed May 6, 2024
    Configuration menu
    Copy the full SHA
    8735c1a View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. fix(language toggle button): show only ay or aleph.

    @YishaiGlasner
    YishaiGlasner committed May 8, 2024
    Configuration menu
    Copy the full SHA
    92531e7 View commit details
    Browse the repository at this point in the history

  2. fix(layout toggle): show bilayout when there is an 'empty' translation.

    @YishaiGlasner
    YishaiGlasner committed May 8, 2024
    Configuration menu
    Copy the full SHA
    bba4437 View commit details
    Browse the repository at this point in the history

  3. fix(layout toggle): don't show layout toggle when the panel is biling… 

    …ual and not wide enough.
    @YishaiGlasner
    YishaiGlasner committed May 8, 2024
    Configuration menu
    Copy the full SHA
    7537960 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. fix(A button): fix location.

    @YishaiGlasner
    YishaiGlasner committed May 9, 2024
    Configuration menu
    Copy the full SHA
    5379fae View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. fix(text menu): fix location.

    @YishaiGlasner
    YishaiGlasner committed May 15, 2024
    Configuration menu
    Copy the full SHA
    83f3334 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'rtl' of https://github.com/Sefaria/Sefaria-Project into… 

    … rtl
    @YishaiGlasner
    YishaiGlasner committed May 15, 2024
    Configuration menu
    Copy the full SHA
    dc7d646 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. feat(connections panel): menu of 'show source' and 'show translation'… 

    … when connections panel shows text.
    @YishaiGlasner
    YishaiGlasner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    c86cdab View commit details
    Browse the repository at this point in the history

  2. fix(connections panel): fix text align and direction in connection pa… 

    …nel when showing rtl texts.
    @YishaiGlasner
    YishaiGlasner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    c4fb810 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Merge branch 'master' into rtl

    @YishaiGlasner
    YishaiGlasner committed May 19, 2024
    Configuration menu
    Copy the full SHA
    36a4439 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Validate interface language is sticky when source language changes

    @b-w-cole
    b-w-cole committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    3e60399 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Merge branch 'master' into sticky-interface-and-source-language

    @b-w-cole
    b-w-cole committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    170d3ce View commit details
    Browse the repository at this point in the history

  2. Parameterized tests for brevity

    @b-w-cole
    b-w-cole committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    c120aa6 View commit details
    Browse the repository at this point in the history

  3. Initial Commit of Translation Version Name in Title Bar 

    Sefaria/Sefaria-Playwright-Tests#18

TODO: Decide if we want to test for default translation title.
    @b-w-cole
    b-w-cole committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    622d4c7 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Testing for default source language only 

    Issue noted for Hebrew sources - no default translation is
selected.
    @b-w-cole
    b-w-cole committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    353d8e9 View commit details
    Browse the repository at this point in the history

  2. Neatening parameters

    @b-w-cole
    b-w-cole committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    f1136b2 View commit details
    Browse the repository at this point in the history

  3. Updating Interface language test

    @b-w-cole
    b-w-cole committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    0197eed View commit details
    Browse the repository at this point in the history

  4. Expanding test to include different sources, plus utils addition

    @b-w-cole
    b-w-cole committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    acb07a8 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Expanding tests to handle bilingual source texts 

    Also allowing default translation validations to be skipped for
Hebrew language source texts
    @b-w-cole
    b-w-cole committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    018f556 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Updated test with new global params

    @b-w-cole
    b-w-cole committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    0bb0ec0 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. feat(rtl): add caching using Sefaria methods, fixing infinite scroll … 

    …and title loading
    @akiva10b
    akiva10b committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    60c6b09 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into rtl-client

    @akiva10b
    akiva10b committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    4ed4d05 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. fix(ReaderPanel): check data exists in shouldLayoutUpdate.

    @YishaiGlasner
    YishaiGlasner committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    51de1de View commit details
    Browse the repository at this point in the history

  2. fix(DisplayOptoinsMenu): fix scrolling when menu is open.

    @YishaiGlasner
    YishaiGlasner committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    1d8cce2 View commit details
    Browse the repository at this point in the history

  3. fix(DisplayOptoinsMenu): fix text vertical align.

    @YishaiGlasner
    YishaiGlasner committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    51af0e7 View commit details
    Browse the repository at this point in the history

  4. chore: remove console.log.

    @YishaiGlasner
    YishaiGlasner committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    400442b View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. refactor(client refs): use new API in getRef, and get contextRef with… 

    … getRef.
    @YishaiGlasner
    YishaiGlasner committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    c052ee6 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. fix(rtl): show ltr text in connections panel commentary in heberw int… 

    …erface.
    @YishaiGlasner
    YishaiGlasner committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    68a514c View commit details
    Browse the repository at this point in the history

  2. fix(rtl): Fix Base version shows as "merged" even when it's coming fr… 

    …om only 1 version.

the text API didn't used to send a list of all the versions when there was only 1 version, now it does - this is either an API bug, or a client side bug. If it is an API bug - we should only externalize the version and keep the log `!!d.sources`
    @akiva10b
    akiva10b committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8f300a6 View commit details
    Browse the repository at this point in the history

  3. fix(rtl): do not show language option in connections panel on hebrew … 

    …interface.
    @YishaiGlasner
    YishaiGlasner committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    af9f192 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. fix(popup): show popup menu over banner

    @YishaiGlasner
    YishaiGlasner committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    ebd5dc3 View commit details
    Browse the repository at this point in the history

  2. refactor: remove TextManager (a previous attempt for api and cache cl… 

    …ass)
    @YishaiGlasner
    YishaiGlasner committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    a58ff8b View commit details
    Browse the repository at this point in the history

  3. fix(TextRange): use isSpanning rather than spanning which doesn't exi… 

    …st in v3.
    @YishaiGlasner
    YishaiGlasner committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    48c14b7 View commit details
    Browse the repository at this point in the history

  4. fix(getObjectFromUrlParam): do not return pipe as language.

    @YishaiGlasner
    YishaiGlasner committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    f423e75 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. fix(TextRange): handle segment refs and spanning refs.

    @YishaiGlasner
    YishaiGlasner committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c74abc2 View commit details
    Browse the repository at this point in the history

  2. refactor(text fetch): move logic of getting context to sefaria.js fun… 

    …ction.
    @YishaiGlasner
    YishaiGlasner committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    bd17129 View commit details
    Browse the repository at this point in the history

  3. fix(text fetch): use context on ReaderPanel.

    @YishaiGlasner
    YishaiGlasner committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    17a7917 View commit details
    Browse the repository at this point in the history

  4. fix(author page): do not show bilingual text for books (rather fallba… 

    …ck to interface text - that is not the desired behaviour but this will have to wait for big refactor of strings languages).
    @YishaiGlasner
    YishaiGlasner committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    549a28c View commit details
    Browse the repository at this point in the history

  5. fix(useContentLang): use the right attribute of data.

    @YishaiGlasner
    YishaiGlasner committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5e9261e View commit details
    Browse the repository at this point in the history

  6. fix(rtl): convert TranslationBox component to functional component

    @akiva10b
    akiva10b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e02f3c6 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'rtl-client' of https://github.com/Sefaria/Sefaria-Project… 

    … into rtl-client
    @akiva10b
    akiva10b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8cd54f6 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/bug/sc-27995/base-version-shows-… 

    …as-merged-even-when-it' into rtl-client
    @akiva10b
    akiva10b committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    946ba45 View commit details
    Browse the repository at this point in the history

  9. fix(TextRange): use withContext in text call.

    @YishaiGlasner
    YishaiGlasner committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    df2779f View commit details
    Browse the repository at this point in the history

  10. fix(API texts v3): add spanningRefs only if isSpanning (=not in the c… 

    …ase of segment ref).
    @YishaiGlasner
    YishaiGlasner committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    fe9c00b View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. fix(translations box): show translation also when the content languag… 

    …e is he.
    @YishaiGlasner
    YishaiGlasner committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e4018a6 View commit details
    Browse the repository at this point in the history

  2. fix(segmentText): fix rtl class (for viewing version in VersionTextLi… 

    …st).
    @YishaiGlasner
    YishaiGlasner committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4b102bb View commit details
    Browse the repository at this point in the history

  3. fix(direction): show source when translation is not available, but al… 

    …so show translation in side panel when contentLang is he.
    @YishaiGlasner
    YishaiGlasner committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    75ce06b View commit details
    Browse the repository at this point in the history

  4. redactor(VersionsTextList): refactor VersionsTextList out of Translat… 

    …ionsBox (for using it in AboutBox).
    @YishaiGlasner
    YishaiGlasner committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    33be1dd View commit details
    Browse the repository at this point in the history

  5. fix(VersionsTextList): move proptypes.

    @YishaiGlasner
    YishaiGlasner committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ab46fcc View commit details
    Browse the repository at this point in the history

  6. refactor(VersionsTextList): render VersionsTextList with AboutBox whe… 

    …n viewing a source version.
    @YishaiGlasner
    YishaiGlasner committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8ee48d6 View commit details
    Browse the repository at this point in the history

  7. fix(VersionsTextList): find languageFamilyName in VersionsTextList. f… 

    …or that add versionLangMap as a prop.
    @YishaiGlasner
    YishaiGlasner committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9620756 View commit details
    Browse the repository at this point in the history

  8. fix(VersionsTextList): add new mode 'Version Open' to histories and S… 

    …SR'.
    @YishaiGlasner
    YishaiGlasner committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7856ff3 View commit details
    Browse the repository at this point in the history

  9. feat(VersionsTextList): do not push about versions into recentVersion… 

    …Filters, and do not show recentVersionFilters on AboutBox (if we want to show them, we should have a different list).
    @YishaiGlasner
    YishaiGlasner committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6210dd3 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. fix(AboutBox): bind setFilter for prevConnectionsMode be 'About'.

    @YishaiGlasner
    YishaiGlasner committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5922f1f View commit details
    Browse the repository at this point in the history

  2. fix(useOutsideClick): add the option not to add a listener (for case … 

    …when the component is not active), and usw it in PopoverMenu when menu is not open.

Also removes memo from TranslationsBox for it was added to solve this bug and not needed anymore.
    @YishaiGlasner
    YishaiGlasner committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    29e798b View commit details
    Browse the repository at this point in the history

  3. refactor(PopoverMenu): get anonymous function out of jsx.

    @YishaiGlasner
    YishaiGlasner committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    027feb9 View commit details
    Browse the repository at this point in the history

  4. fix(AboutBox): use ContentText for the composed text (rather than no … 

    …component), so it won't show both languages.
    @YishaiGlasner
    YishaiGlasner committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    ac12844 View commit details
    Browse the repository at this point in the history

  5. fix(AboutBox): show the title of current version rather than of the l… 

    …ast translation.

this is done by passing the current vFilter to VersionsTextList, so recentFilters removed from AboutBox.
    @YishaiGlasner
    YishaiGlasner committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    699294d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into rtl-client

    @YishaiGlasner
    YishaiGlasner committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a0ceb87 View commit details
    Browse the repository at this point in the history

  7. chore: remove debugger.

    @YishaiGlasner
    YishaiGlasner committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    2ad18ec View commit details
    Browse the repository at this point in the history

  8. fix(ReaderControls): set translation versionTitle even when only sour… 

    …ce is shown for using it when toggle to translation.
    @YishaiGlasner
    YishaiGlasner committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    6ee6d4f View commit details
    Browse the repository at this point in the history

  9. fix(ConnectionsPanel): load data when moving from section to segment … 

    …ref, for availabe trasnlations for section can be partial.
    @YishaiGlasner
    YishaiGlasner committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    f7cdb4a View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Solving issue with flakey tests by clearing cookies for each test 

    Issue: Tests time out on assertions looking for text in the wrong
language

Solution: Clearing the cookies resets the cookie-setting process and allows
language cookies to be refreshed for each context.
    @b-w-cole
    b-w-cole committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b953eaf View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. fix(css): do not show rtl-translation//ltr-source when viewing source… 

    …/translation only.
    @YishaiGlasner
    YishaiGlasner committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e72c264 View commit details
    Browse the repository at this point in the history

  2. fix(css): show ltr source when selecting translation but no translati… 

    …on exists.
    @YishaiGlasner
    YishaiGlasner committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    682fad5 View commit details
    Browse the repository at this point in the history

  3. fix(AboutBox): check if versionLangMap were loaded in the right way.

    @YishaiGlasner
    YishaiGlasner committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    daa3744 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. chore(testing): add ip control for bilingual tests

    @akiva10b
    akiva10b committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e5131aa View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. feat(versions): get the translation by the user langauge preferences … 

    …and version stickiness.
    @YishaiGlasner
    YishaiGlasner committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    af8b795 View commit details
    Browse the repository at this point in the history

  2. ci: allow integration tests to be run by hand

    @BrendanGalloway
    BrendanGalloway committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    7cbe48a View commit details
    Browse the repository at this point in the history

  3. chore: indentation.

    @YishaiGlasner
    YishaiGlasner committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    827ded3 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. feat: use old _saveText for enabling the using of getRefFromCache.

    @YishaiGlasner
    YishaiGlasner committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    da574bb View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2058 from Sefaria/manual-integration 

    ci: allow integration tests to be run by hand
    @akiva10b
    akiva10b authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    f04d45c View commit details
    Browse the repository at this point in the history

  3. refactor(AddToSourceSheet): refactor 3 functions out of addToSourceSh… 

    …eet.
    @YishaiGlasner
    YishaiGlasner committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    46faebf View commit details
    Browse the repository at this point in the history

  4. refactor(AddToSourceSheet): use the full current version objects.

    @YishaiGlasner
    YishaiGlasner committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    9a97fe2 View commit details
    Browse the repository at this point in the history

  5. ci: don't skip on manual workflow

    @BrendanGalloway
    BrendanGalloway committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    fa91c48 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #2060 from Sefaria/manual-integration 

    ci: don't skip on manual workflow
    @akiva10b
    akiva10b authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1c6a0ac View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. feat: add source to sheet when source is ltr or translation rtl, and … 

    …when both of them have the same direction (in the last case - do 2 posts).
    @YishaiGlasner
    YishaiGlasner committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6fab6ed View commit details
    Browse the repository at this point in the history

  2. refactor(get texts): refactor getPrimaryAndTranslationFromVersions ou… 

    …t of _adaptApiResponse, for using elsewhere.
    @YishaiGlasner
    YishaiGlasner committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7d341e5 View commit details
    Browse the repository at this point in the history

  3. chore: remove console.log.

    @YishaiGlasner
    YishaiGlasner committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9c00683 View commit details
    Browse the repository at this point in the history

  4. fix(AboutBox): fix versions in AboutBox

    @YishaiGlasner
    YishaiGlasner committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    410b621 View commit details
    Browse the repository at this point in the history

  5. chore: remove console.log.

    @YishaiGlasner
    YishaiGlasner committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    88c94af View commit details
    Browse the repository at this point in the history

  6. fix(add to sheet): add to sheet from sheet of source that is spanning… 

    … ref (ConnectionsPanel should call all the section for caching).
    @YishaiGlasner
    YishaiGlasner committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d5a48c6 View commit details
    Browse the repository at this point in the history

  7. fix(open version): fix open version from toc page.

    @YishaiGlasner
    YishaiGlasner committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9abe2e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. fix(TextRange): show linkCount when it's available.

    @YishaiGlasner
    YishaiGlasner committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    c9aa2b3 View commit details
    Browse the repository at this point in the history

  2. fix: align hebrew source in side panel to right also on english inter… 

    …face.
    @YishaiGlasner
    YishaiGlasner committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    dca9028 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. chore: typo

    @YishaiGlasner
    YishaiGlasner committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2e0404a View commit details
    Browse the repository at this point in the history

  2. feat(sheet): sheet display options menu which inclusdes: 

    fontsize
for english interface (=bilingual content) - layouts of rtl and ltr.
    @YishaiGlasner
    YishaiGlasner committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    cb819a8 View commit details
    Browse the repository at this point in the history

  3. feat(sheet): fix the language - he for hebrew interface, and bi for e… 

    …nglish interface.
    @YishaiGlasner
    YishaiGlasner committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    de35485 View commit details
    Browse the repository at this point in the history

  4. feat(sheet): redirect (permanent, 301) the language of sheet - he for… 

    … hebrew interface, and bi for english interface.

Implications 301 for SEO
Permanent change: 301 can be used for permanent URL changes. These include such things as site migrations or merging pages.
Link authority: a 301 redirect retains up to 90-99% of link authority. This is essential for SEO.
User experience: it is important to create a good transition for users following old bookmarks or links.
    @YishaiGlasner
    YishaiGlasner committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2945264 View commit details
    Browse the repository at this point in the history

  5. feat(sheet): display ltr-only sources on hebrew interface.

    @YishaiGlasner
    YishaiGlasner committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    8ed551f View commit details
    Browse the repository at this point in the history

  6. fix(sheet): fix flow.

    @YishaiGlasner
    YishaiGlasner committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a9874cd View commit details
    Browse the repository at this point in the history

  7. fix(TextRange): fix loading message in bilingual state. Use LoadingMe… 

    …ssage rather than ContentText for that.
    @YishaiGlasner
    YishaiGlasner committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    4c26e77 View commit details
    Browse the repository at this point in the history

  8. fix(TextRange): typo.

    @YishaiGlasner
    YishaiGlasner committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    efb0bd0 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into rtl-client

    @YishaiGlasner
    YishaiGlasner committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    8c6066a View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. refactor(DropdownMenu): change name from PopoverMeni.

    @YishaiGlasner
    YishaiGlasner committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    12bac89 View commit details
    Browse the repository at this point in the history

  2. refactor(components): rename folder to common.

    @YishaiGlasner
    YishaiGlasner committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2820045 View commit details
    Browse the repository at this point in the history

  3. chore(DropDownMenu): typo.

    @YishaiGlasner
    YishaiGlasner committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d65bc31 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/language-selection-playwright-te… 

    …sts' into rtl-client
    @YishaiGlasner
    YishaiGlasner committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    78b73f7 View commit details
    Browse the repository at this point in the history

  5. test: fix tests for interface language.

    @YishaiGlasner
    YishaiGlasner committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    720dd99 View commit details
    Browse the repository at this point in the history

  6. test(playwright): fix tests for translation version name.

    @YishaiGlasner
    YishaiGlasner committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    403ac3c View commit details
    Browse the repository at this point in the history

  7. refactor(playwright): user changeLanguageOfText rather than duplicate… 

    … code.
    @YishaiGlasner
    YishaiGlasner committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    083bf4f View commit details
    Browse the repository at this point in the history

  8. fix(playwright): fix reader.spec tests.

    @YishaiGlasner
    YishaiGlasner committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2188525 View commit details
    Browse the repository at this point in the history

  9. refactor(DropdownMenu): option for using without context from outside… 

    …, but rather with state.
    @YishaiGlasner
    YishaiGlasner committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    5d6851a View commit details
    Browse the repository at this point in the history

  10. fix: fix direction of book hebrew title in side panel, and of the con… 

    …tent itself even when it os one line (both in english interface).
    @YishaiGlasner
    YishaiGlasner committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    979a6e3 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. fix(text api): add versionStatus and heVersionStatus to the response.

    @YishaiGlasner
    YishaiGlasner committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    46f6699 View commit details
    Browse the repository at this point in the history

  2. fix(ConnectionsPanel): set data in advanced state (for checking the a… 

    …bility to edit text).
    @YishaiGlasner
    YishaiGlasner committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    4ef9c87 View commit details
    Browse the repository at this point in the history

  3. chore: indentation.

    @YishaiGlasner
    YishaiGlasner committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    f2f14a6 View commit details
    Browse the repository at this point in the history

  4. fix(AboutBox): show correctly the 'Current Version' and 'Current Tran… 

    …slation'.
    @YishaiGlasner
    YishaiGlasner committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    feb9230 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. fix(get text): check if version exists also when we know the versionT… 

    …itle (for cases where the user chose a partial version).
    @YishaiGlasner
    YishaiGlasner committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    c888653 View commit details
    Browse the repository at this point in the history

  2. fix(TextSegment): use the directions from the props rather than from … 

    …context (which can be true for only another TextRange).
    @YishaiGlasner
    YishaiGlasner committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4b97f73 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. fix(css): show only the interface text for topic in the side panel.

    @YishaiGlasner
    YishaiGlasner committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    0611f8b View commit details
    Browse the repository at this point in the history

  2. fix(translations): show the number of translations on the specific se… 

    …gment, rather than for whole section. for this use props.srefs[0] (in accordance with what we use inside TranslationsBox).
    @YishaiGlasner
    YishaiGlasner committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    d355740 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. fix(versions): case where we don't have the translation requested ver… 

    …sion (like we have it for some sections).
    @YishaiGlasner
    YishaiGlasner committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    57094fa View commit details
    Browse the repository at this point in the history

  2. fix(versions stickiness): stickiness for all translations rather than… 

    … ltr only.
    @YishaiGlasner
    YishaiGlasner committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    3d2a3fc View commit details
    Browse the repository at this point in the history

  3. fix(currVersions): check for versionTitle before adding it to edit url.

    @YishaiGlasner
    YishaiGlasner committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    bbfac1e View commit details
    Browse the repository at this point in the history

  4. fix(currVersions): check for versionTitle before adding it to edit url.

    @YishaiGlasner
    YishaiGlasner committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    6170901 View commit details
    Browse the repository at this point in the history

  5. fix(edit): edit rtl translations.

    @YishaiGlasner
    YishaiGlasner committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    5dd8073 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. feat(translations): rtl translations with sans serif and 100% font size.

    @YishaiGlasner
    YishaiGlasner committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    5773c83 View commit details
    Browse the repository at this point in the history

  2. fix(connections panel): show only one language in panel side texts.

    @YishaiGlasner
    YishaiGlasner committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d35b171 View commit details
    Browse the repository at this point in the history

  3. fix(hebrew translation): apply stripping vowels for hebrew translations.

    @YishaiGlasner
    YishaiGlasner committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    db543b3 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. feat(hebrew translation): do not grey the text even in stacked view.

    @YishaiGlasner
    YishaiGlasner committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    a49f6ef View commit details
    Browse the repository at this point in the history

  2. fix(ReaderDisplayOptionsMenu): in mobile, do not show layout options … 

    …for bilingual, but only for unilingual.
    @YishaiGlasner
    YishaiGlasner committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    f28b2e1 View commit details
    Browse the repository at this point in the history