-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rtl client #2026
Open
akiva10b
wants to merge
183
commits into
master
Choose a base branch
from
rtl-client
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rtl client #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g them to fit the expected old api response.
… to include an object for any language (he and en) rather than a string. The idea is to enable it to include other details and not only versionTitle.
…mbers and use it rather than placeSegmentNuncers.
…itle should be displayed.
…n there is more than one source.
…n the aources attribute is in the response.
…o components (rather than get it from cache objects).
…ng the translation VersionTitle.
…ned object in ssr processing.
…sts' into rtl-client
…, but rather with state.
…tent itself even when it os one line (both in english interface).
…bility to edit text).
…itle (for cases where the user chose a partial version).
…context (which can be true for only another TextRange).
…gment, rather than for whole section. for this use props.srefs[0] (in accordance with what we use inside TranslationsBox).
…sion (like we have it for some sections).
…for bilingual, but only for unilingual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A brief description of the PR
Code Changes
The following changes were made to the files below
Notes
Any additional notes go here