Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rtl client #2026

Open
wants to merge 183 commits into
base: master
Choose a base branch
from
Open

Rtl client #2026

wants to merge 183 commits into from

Conversation

akiva10b
Copy link
Contributor

@akiva10b akiva10b commented Sep 5, 2024

Description

A brief description of the PR

Code Changes

The following changes were made to the files below

Notes

Any additional notes go here

…g them to fit the expected old api response.
… to include an object for any language (he and en) rather than a string. The idea is to enable it to include other details and not only versionTitle.
…mbers and use it rather than placeSegmentNuncers.
…o components (rather than get it from cache objects).
…tent itself even when it os one line (both in english interface).
…itle (for cases where the user chose a partial version).
…context (which can be true for only another TextRange).
…gment, rather than for whole section. for this use props.srefs[0] (in accordance with what we use inside TranslationsBox).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants