Add SPACE, DEL icons to Keyboard
; various UI consistency tweaks
#664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See affected screenshot changes: SeedSigner/seedsigner-screenshots#5
UPDATE: 2025-01-23:
Per @easyuxd's guidelines, tightened up the icon + color usage (7edcd33):
Note that the goal was to enforce his consistency rules, but I have not implemented his guidelines for when to use which warning/error. I think there are deeper discussions we need to have about what an error means and/or how it is perceived by the user (preview: I think "error" implies something is broken in our code and thus we need to take great care when telling the user there was an error).
And in order to begin to get a better handle on consistently applying those rules, I finally implemented
ScanInvalidQRTypeView
(c0fe676) which had previously been a manually-created View that the screenshot generator had to also manually create to provide the matching screenshot. Note the comment/misgivings about its "Error" title.Misc trivial import cleanup while I was in those files.
Main purpose:
Keyboard
. Slight refactor in there required.UI fixes:
ERROR
icon (we were using theWARNING
exclamation in red instead).UI consistency tweaks:
ERROR
vsWARNING
and red vs yellow.WARNING
in yellow.Minor misc:
Keyboard
: Use ourCHEVRON_LEFT
/CHEVRON_RIGHT
for cursor navigation.load_icon()
function which was an early ~v0.5.0 relic.ButtonListScreen
whereis_bottom_list=True
with more than one button.Keyboard
key size.messages.pot
).ScanView
error when it scans an unsupported QR format.This pull request is categorized as a:
Checklist
pytest
and made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os: