Resolves issue 555 - Improve UX navigating across DEL button (expanding it) #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Growning "del" button size property (from 2 to 3) solves navigation issue ("6th dice" -> "del").
solves issue SeedSigner#555
Additional differents sizes "del" buttons
new custom_additional_keys prop on KeyboardScreen class for can to change additional button (KEY_BACKSPACE) on its childs classes
Changing KEY_BACKSPACE size on BIP39, SeedBIP85, SeedCustomDerivation, symbols_1, symbols_2 screens
Changing KEY_BACKSPACE size on ToolsDiceEntropy and ToolsCoinFlip screens
|
Branch renamed for better understanding. |
Missed import sentence for commands on last commit
|
Fixed missed import sentence on tools_screens.py |
|
#555 link |
|
First of all, thank you @fedebuyito ! As of 3c967a0
Pending code review regarding the KEY_BACKSPACE object. |
|
concept ACK |
fedebuyito
changed the title
|
Code adapted (and tested on emulator) in order to resolve conflicts from last massive merge (PR #620 ) |
fedebuyito
changed the title
fedebuyito
changed the title
|
Code adapted (pytested and tested on emulator) in order to resolve conflicts from merge PR #664 :
Some results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Fixes #555 wich aims to improve user experience when navigating the screens where KEY_BACKSPACE/DEL button is showed. Expand DEL to fill any remaining gap would fix what reported on issue.
Include screenshots of any new or modified screens (or at least explain why they were omitted): Here screenshots, before and after, #555 (comment)
This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.