Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify import typings #622

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Simplify import typings #622

wants to merge 5 commits into from

Commits on Apr 16, 2024

  1. Simplify ImportTypings 

    The logic in ImportTypings is used inside the sbt plugin. cli.Main uses
almost the same logic, as well the mill plugin.
This is the first step to refactor all in one place.
    @andrelfpinto
    andrelfpinto committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ca11883 View commit details
    Browse the repository at this point in the history

  2. Normalize Successes type 

    Successes was the only type to use Dep.Concrete, and only in
ImportTypings. Results and Failures use PublishedSbtProject, as well as
Successes in cli.Main.
    @andrelfpinto
    andrelfpinto committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    be8af30 View commit details
    Browse the repository at this point in the history

  3. Add includeProject

    @andrelfpinto
    andrelfpinto committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1516acf View commit details
    Browse the repository at this point in the history

  4. Extract ImportTypings 

    Extract part of ImportTypings as ImportTypingsUtil in importer-portable.
    @andrelfpinto
    andrelfpinto committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    d572f30 View commit details
    Browse the repository at this point in the history

  5. Use ImportTypingsUtil in cli.Main

    @andrelfpinto
    andrelfpinto committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    d24575a View commit details
    Browse the repository at this point in the history