Simplify import typings #622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic in ImportTypings is used inside the sbt plugin. cli.Main uses almost the same logic, as well the mill plugin. This is the first step to refactor all in one place.
Successes was the only type to use Dep.Concrete, and only in ImportTypings. Results and Failures use PublishedSbtProject, as well as Successes in cli.Main.
Extract part of ImportTypings as ImportTypingsUtil in importer-portable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in ImportTypings is used inside the sbt plugin. cli.Main uses almost the same logic, as well the mill plugin.
This PR tries to refactor all in one place.