Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IT-3964: Add workaround for Node20 runners #125

Merged
merged 3 commits into from
Oct 28, 2024
Merged

IT-3964: Add workaround for Node20 runners #125

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb3b6f8
IT-3964: Add workaround for Node20 runners
JessterB Oct 28, 2024
0a31787
IT-3964: Move new config to jobs.deploy.env
JessterB Oct 28, 2024
789cecd
IT-3964: Move config to global level
JessterB Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
# variables in context environments are setup in github to match branch names
environment:
name: ${{ github.ref_name }}
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, i mislead you in my previous suggestion. I thought env and environment are the same thing, but in actually they are completely different. please take a look at the GH action docs and notice that it's env. You'll need to define an env: at the job level and add ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true to it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, this won't work. The step that's failing is actions/checkout@v4 which is in the test job, this however is scoped to the deploy job. I would move env: to the same level as on: and jobs: making scoped globally in this workflow.


steps:
# use older checkout version due to https://github.com/dawidd6/action-download-artifact/issues/261
Expand Down