-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IT-3964: Add workaround for Node20 runners #125
Conversation
.github/workflows/main.yaml
Outdated
@@ -21,6 +21,7 @@ jobs: | |||
# variables in context environments are setup in github to match branch names | |||
environment: | |||
name: ${{ github.ref_name }} | |||
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, i mislead you in my previous suggestion. I thought env
and environment
are the same thing, but in actually they are completely different. please take a look at the GH action docs and notice that it's env
. You'll need to define an env:
at the job level and add ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, this won't work. The step that's failing is actions/checkout@v4
which is in the test
job, this however is scoped to the deploy
job. I would move env:
to the same level as on:
and jobs:
making scoped globally in this workflow.
.github/workflows/main.yaml
Outdated
@@ -21,6 +21,7 @@ jobs: | |||
# variables in context environments are setup in github to match branch names | |||
environment: | |||
name: ${{ github.ref_name }} | |||
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, this won't work. The step that's failing is actions/checkout@v4
which is in the test
job, this however is scoped to the deploy
job. I would move env:
to the same level as on:
and jobs:
making scoped globally in this workflow.
No description provided.