Wall tactic #1661
Merged
Wall tactic #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2e6e543.
HussainGynai
suggested changes
Jun 14, 2021
kfu02
commented
Jun 14, 2021
HussainGynai
approved these changes
Jun 15, 2021
kfu02
commented
Jun 15, 2021
kylestach
suggested changes
Jun 15, 2021
This was referenced Jun 15, 2021
kfu02
requested review from
kylestach,
Yudai-8-om and
HussainGynai
and removed request for
Yudai-8-om
Open
|
'fix invisible robot assignment' fixed the flaky wall assignment issues, as some robots that weren't visible were being assigned to be part of the wall |
kfu02
commented
Jun 16, 2021
| for i in range(self.num_wallers) | ||
| } | ||
|
|
||
| for se, rr in role_requests.items(): |
There was a problem hiding this comment.
take out these debug prints
There was a problem hiding this comment.
done in different PR, ignore for now
kylestach
reviewed
Jun 17, 2021
Co-authored-by: Kyle Stachowicz <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates wall tactic, which builds a wall of n robots between the ball and the goal.
Associated Issue
https://app.clickup.com/t/v5cpe0
Steps to test
Test Case 1
Expected result: 3 robots (ids 0-2) should move to form a wall and track the ball (relatively) smoothly. They should block the ball from being scored. They should also never enter the penalty box or touch its bounding lines.
Test Case 2
init()method of gameplay'splay/wall_ball.pythat controls how many robots are in the wall tacticExpected result: N robots should move now, same behavior as before.
Known Issues
This is not true; both move action and move skill have a face_point. Relaunch sim if this error pops up.