Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TODO] Use param node properly in gameplay #1666

Open
kfu02 opened this issue Jun 15, 2021 · 0 comments
Open

[TODO] Use param node properly in gameplay #1666

kfu02 opened this issue Jun 15, 2021 · 0 comments
Labels
exp / novice (1) priority / low pull request todo From a TODO in code

Comments

@kfu02
Copy link
Contributor

kfu02 commented Jun 15, 2021

Pull request: #1661

Link to TODO, or file number/line:
https://github.com/RoboJackets/robocup-software/pull/1661/files#r652124038

There are a bunch of python constants that should be local params with our new param node (#1650), but aren't because no one learned how to use the new param node before comp crunch. We should go through and make all those local/global params as needed. (This includes the constants.py file in stp/utils/.)
@kfu02 kfu02 mentioned this issue Jun 15, 2021
Merged
@kfu02 kfu02 changed the title [TODO] [TODO] Use param node properly in gameplay Jun 15, 2021
@kfu02 kfu02 mentioned this issue Jun 16, 2021
Merged
@kasohrab kasohrab mentioned this issue May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp / novice (1) priority / low pull request todo From a TODO in code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kfu02