Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ease pyyaml constraint #12678

Closed
wants to merge 3 commits into from
Closed

Ease pyyaml constraint #12678

wants to merge 3 commits into from

Conversation

vcidst
Copy link
Contributor

@vcidst vcidst commented Jul 19, 2023 •
edited
Loading

Proposed changes:

  • PyYAML constraint <6.0 was breaking CI, removed it
  • This PR fails Code Quality test because of lint errors from Ruff. This is because the source branch upgraded ruff, I would suggest we downgrade ruff back to 0.0.255 and create a ticket to update it later

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@vcidst vcidst requested a review from a team as a code owner July 19, 2023 12:26
@vcidst vcidst requested a review from varunshankar July 19, 2023 12:26
This was referenced Jul 19, 2023
Merged
Merged
@vcidst
Copy link
Contributor Author

vcidst commented Jul 19, 2023

Not required after #12679

@vcidst vcidst closed this Jul 19, 2023
@vcidst vcidst deleted the housekeeping-48 branch July 19, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urkem Urkem Urkem approved these changes

@varunshankar varunshankar Awaiting requested review from varunshankar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vcidst @Urkem