Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping: python package deps upgrade #12670

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Housekeeping: python package deps upgrade #12670

merged 7 commits into from
Jul 28, 2023

Conversation

varunshankar
Copy link
Contributor

@varunshankar varunshankar commented Jul 17, 2023 •
edited
Loading

Proposed changes:

not upgrading ruff, created a JIRA ticket instead: https://rasahq.atlassian.net/browse/ENG-440

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@varunshankar varunshankar self-assigned this Jul 17, 2023
This was referenced Jul 17, 2023
Closed
Closed
Closed
ancalita
ancalita reviewed Jul 17, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@vcidst
Copy link
Contributor

vcidst commented Jul 19, 2023

@varunshankar I've bumped pyyaml to >6.0 in #12678 which seems to address the CI errors

ancalita
ancalita approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left only 1 question to be addressed, otherwise LGTM 👍🏻

.github/scripts/download_pretrained.py Outdated Show resolved Hide resolved
djcowley
djcowley approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@djcowley djcowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@varunshankar varunshankar merged commit e772749 into main Jul 28, 2023
98 checks passed
@varunshankar varunshankar deleted the 0717-housekeeping branch July 28, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djcowley djcowley djcowley approved these changes

@ancalita ancalita ancalita approved these changes

@vcidst vcidst Awaiting requested review from vcidst

Assignees

@varunshankar varunshankar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@varunshankar @vcidst @djcowley @ancalita