Feat/147 update calls to write manifest #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update required version of `pacta.data.preparation`
Create an input_filepaths object, rather than use individual filepaths
…lls-to-write_manifest
adjust code to account for changes made in #150
|
Marking as ready for review, with notes about the PRs that should be considered first. |
|
putting into draft mode because this depends on other PRs, and as such, it's nearly impossible to review properly |
cjyetman
reviewed
Feb 23, 2024
cjyetman
reviewed
Feb 23, 2024
Co-authored-by: CJ Yetman <[email protected]>
Removed block of code that would check for existence of a directory that is created earlier in script.
Co-authored-by: CJ Yetman <[email protected]>
cjyetman
requested changes
Feb 23, 2024
Co-authored-by: CJ Yetman <[email protected]>
Use the `output_files` list of filepaths for archive step.
cjyetman
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update run_data_preparation to use changed function in https://github.com/RMI-PACTA/pacta.data.preparation/pull/341.
Also simplifies somewhat the logic around the list of input filepaths.
Should be merged after that, but coordinated closely.
Note: as-written, this includes #150, but reverting back to 35fd720 removes that dependency.
Also as written, depends on #153, as this does a similar simplification from
list.files()to explicit filepath lists for the archive export feature defined in that PR. Reverting 1b8cd49 removes that connection.Closes #147