Optional icons for server-side RUI announcements. #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs testing
JMM889901
approved these changes
Sep 30, 2024
| @@ -453,6 +454,7 @@ void function AnnouncementMessageHandler_Threaded() | |||
| Announcement_SetPriority( announcement, client.announcementQueue[0].priority ) | |||
| Announcement_SetSoundAlias( announcement, SFX_HUD_ANNOUNCE_QUICK ) | |||
| Announcement_SetStyle( announcement, client.announcementQueue[0].style ) | |||
| Announcement_SetIcon( announcement, StringToAsset( strip( client.announcementQueue[0].image ) ) ) | |||
There was a problem hiding this comment.
Seems weird that they are stored in the struct as a string and converted to asset here but eh, probably still the best way to do it
Alystrasz
approved these changes
Oct 5, 2024
There was a problem hiding this comment.
Code looks good, and feature works in game.
I could display images with the updated command; not passing the last parameter to it simply doesn't display any image.
Testing
Using the following command:
script NSSendAnnouncementMessageToPlayer(GetPlayerArray()[0], "FIRE", "I’M A’ FIRIN’ MAH LAZER!!", <1,0,1>, 1, 1, "rui/hud/scoreboard/status_dead")
I get:
Alystrasz
added
READY TO MERGE
|
Will add this to the next feature release. Just need push out a patch release first. So consider this essentially merged. I'll hopefully have some time tomorrow or something to figure out the strategy for the next few releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds optional icon support for server-side RUI announcements.
